Capture all Netkan error text after first hyphen

[HebaruSan]

Problem

The status page currently truncates error messages.

If you try to process CareerModePartCostNullifer manually with netkan.exe, it says:

2656 [1] FATAL CKAN.NetKAN.Program (null) - C:\Users\User\AppData\Local\Temp\CdFileMgr\303747d7-0830-4d.tmp is not a valid ZIP file: Error in step EntryHeader for Budget part cost set to 0.cfg: Exception during test - 'Compression method not supported'

But the status page only says: 'Compression method not supported'

Cause

This line extracts everything after the final hyphen in the output:

NetKAN-bot/lib/App/KSP_CKAN/Tools/NetKAN.pm

Line 153 in 81751de

$error =~ m{FATAL.+.-.(.+)}m;

The first .+ matches as many characters as it can, including hyphens if there are multiple. So the (.+) part only matches the text after the last hyphen.

Changes

Now the .+ in that regex is changed to .+?, which makes it non-greedy, so the regex's hyphen will match the first one in the output rather than the last one. This will make the (.+) match the whole error.

[coveralls]

Coverage remained the same at 91.677% when pulling 49e3508 on fix/error-parsing into 81751de on master.

[techman83]

Once my family heads back I'll make some time to sort out the Bot PRs @HebaruSan

[techman83]

Ok, merging this in. I'll add a test and fix the broken ones.

[techman83]

@HebaruSan done + deployed 🙂