Skip to content
This repository has been archived by the owner on Apr 13, 2021. It is now read-only.

Fix NetKAN staging #66

Merged
merged 1 commit into from
Aug 16, 2018
Merged

Fix NetKAN staging #66

merged 1 commit into from
Aug 16, 2018

Conversation

HebaruSan
Copy link
Member

Background

The NetKAN bot has a "staging" option that is intended to allow for manual review of bot updates before they go into CKAN-meta. If you put this in your .netkan:

    "x_netkan_staging": true,

... then the bot will put your mod's updates in a separate branch and submit a pull request on GitHub, which can then have the validation scripts run and be merged by metadata maintainers if it looks OK.

The following modules currently have metadata set up to use this feature:

  • ContractConfigurator-HistoricMissions
  • ContractConfigurator-HistoricMissionsRSS
  • FerramAerospaceResearch
  • Kopernicus
  • KSPInterstellarExtended
  • MilitaryVehicleChassis
  • PlanetWiki-OPM
  • RoverFuelTanks
  • RoverWheelSounds
  • SovietConversion
  • StockVisualEnhancements
  • SVE-HighResolution
  • SVE-LowResolution
  • SVE-MediumResolution

Problem

Currently the metadata does not trigger the feature. Those mods are not going through a staging procedure when they update.

Cause

The property name is wrong in the Perl code; the hyphens should be underscores:

method _build_staging {
return $self->_raw->{config}{'x-netkan-staging'} ? $self->_raw->{config}{'x-netkan-staging'} : 0 ;
}

So the feature is implemented and live, but it's not being used.

Changes

Now the correct property name is used. This will enable staging.

(Also fixed spelling of "commited" in a few message strings.)

Fixes #60.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 91.677% when pulling 714e546 on fix/staging into 3a659d7 on master.

Copy link
Member

@techman83 techman83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests pass now (dependency was briefly having an issue on 5.20).

Thanks for updating this!

@techman83 techman83 merged commit 75e4c35 into master Aug 16, 2018
@techman83 techman83 deleted the fix/staging branch August 16, 2018 03:51
@politas
Copy link
Member

politas commented Aug 23, 2018

I was wondering why nothing seemed to come through the staging process.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Correct NetKAN staging metadata parser
4 participants