This repository has been archived by the owner on Apr 13, 2021. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
The NetKAN bot has a "staging" option that is intended to allow for manual review of bot updates before they go into CKAN-meta. If you put this in your .netkan:
... then the bot will put your mod's updates in a separate branch and submit a pull request on GitHub, which can then have the validation scripts run and be merged by metadata maintainers if it looks OK.
The following modules currently have metadata set up to use this feature:
Problem
Currently the metadata does not trigger the feature. Those mods are not going through a staging procedure when they update.
Cause
The property name is wrong in the Perl code; the hyphens should be underscores:
NetKAN-bot/lib/App/KSP_CKAN/Metadata/NetKAN.pm
Lines 102 to 104 in 3a659d7
So the feature is implemented and live, but it's not being used.
Changes
Now the correct property name is used. This will enable staging.
(Also fixed spelling of "commited" in a few message strings.)
Fixes #60.