Skip to content
This repository has been archived by the owner on Apr 13, 2021. It is now read-only.

Sorting and line breaks for the download counts #72

Merged
merged 2 commits into from
Aug 29, 2018
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion lib/App/KSP_CKAN/DownloadCounts.pm
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,11 @@ method _build__http {
}

method _build__json {
return JSON->new->allow_blessed(1)->convert_blessed(1);
return JSON->new
->indent(1)
->canonical(1)
->allow_blessed(1)
->convert_blessed(1);
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of these should be passable to plain JSON, looking at JSON:XS that'll be fine.

return JSON->new
  ->allow_blessed(1)
  ->convert_blessed(1)
  ->pretty(1)
  ->canonical(1);

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, all of them work except for indent_length, and I'm not about to argue for the necessity of zero indentation.

method _build__NetKAN {
Expand Down