This repository has been archived by the owner on Apr 13, 2021. It is now read-only.
Override cache for web hook inflate #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
KSP-CKAN/CKAN#2582 is merged. |
techman83
approved these changes
Nov 30, 2018
| ); | ||
| push @opts, '--github-token=' . $self->token if $self->token; | ||
| push @opts, '--overwrite-cache' if $self->overwrite; | ||
| return join(' ', $self->netkan, @opts, $self->file); | ||
| } |
There was a problem hiding this comment.
This is really neat, I like it.
| $self->ckan_meta->reset(file => $file); | ||
| return 0; | ||
| } | ||
|
|
||
| if ( ! $self->_netkan_metadata->staging ) { | ||
| $self->info("Commiting $changed"); | ||
| $self->info("Committing $changed"); | ||
| $self->ckan_meta->commit( |
There was a problem hiding this comment.
Haha, thank you for the spelling fixes
|
@HebaruSan - SpaceDocks webhook service probably needs to be updated to point at the new domain. Also your webhook @NathanKell likely needs the same. |
|
Good point, opened KSP-SpaceDock/SpaceDock#192 to request that. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
If a mod author uploads a release to SpaceDock, then deletes it and re-uploads the same version with a changed file (usually because the first version had an error), the original version will remain in the Netkan bot's cache, and the metadata for that release will have an incorrect file size and hashes. Resolving this situation requires having @techman83 manually purge the files from the bot's cache.
Related pull request
KSP-CKAN/CKAN#2582 added a
netkan.exe --overwrite-cacheoption. This will delete the cached file so it can be re-downloaded for indexing.Changes
This pull request updates the Perl scripts to pass the
--overwrite-cacheparameter when inflating from the web hook. This should eliminate the need to manually purge files from the bot's cache.