Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make RPM install Correctly #10

Merged
merged 2 commits into from
Nov 12, 2014
Merged

Make RPM install Correctly #10

merged 2 commits into from
Nov 12, 2014

Conversation

KevinCathcart
Copy link
Contributor

Fix the installation location of RasterPropMonitor in light of KSP-CKAN/CKAN#287. Also add documentation links, and add $vref into the core module.

@pjf
Copy link
Member

pjf commented Nov 12, 2014

Oh no, we didn't break anything with KSP-CKAN/CKAN#287, did we?

@pjf
Copy link
Member

pjf commented Nov 12, 2014

Oh! I guess we did, because GameData/JSI/RasterPropMonitor would then try to install to GameData/RasterPropMonitor, which is not where it should go.

Once we get installing to subfolders ( KSP-CKAN/CKAN#315 ) working, I imagine a lot of the hassles of "grab this directory and place it here" will become much simpler.

Merging these once I get near a command-line. :)

pjf added a commit that referenced this pull request Nov 12, 2014
@pjf pjf merged commit c1eec06 into KSP-CKAN:master Nov 12, 2014
@KevinCathcart
Copy link
Contributor Author

@pjf: Just for the record, KSP-CKAN/CKAN#287 did technically not break this.

I make that statement on the grounds that it was actually merged first. One cannot blame a merged patch for breaking a pending patch. Now, it did break ModuleManager, but that was fixed almost immediately. I was unable to find any other affected NetKAN/CKAN files, although I won't swear that I did not miss any.

mheguy pushed a commit that referenced this pull request Feb 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants