Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed dir structure error #2383

Merged
merged 3 commits into from Oct 8, 2015
Merged

Fixed dir structure error #2383

merged 3 commits into from Oct 8, 2015

Conversation

qm3ster
Copy link
Contributor

@qm3ster qm3ster commented Oct 6, 2015

Problem described here - http://forum.kerbalspaceprogram.com/threads/121224-1-04-Mk2-Expansion-v1-6-UDATE-9-24-2015?p=2231443&viewfull=1#post2231443
Don't know if epoch needs to be bumped over that or not.
Tested compatibility with all available on Kerbal Stuff versions, that's why not a version override.

Problem described here - http://forum.kerbalspaceprogram.com/threads/121224-1-04-Mk2-Expansion-v1-6-UDATE-9-24-2015?p=2231443&viewfull=1#post2231443
Don't know if epoch needs to be bumped over that or not.
Tested compatibility with all available on Kerbal Stuff versions, that's why not a version override.
More user compatability
Mod author changed directory structure again, in the meantime before my pull request was accepted.
@qm3ster
Copy link
Contributor Author

qm3ster commented Oct 8, 2015

Rationale explained in link in graphic detail, but basically the fact that a new version suddenly packed it as Mk2Expansion/GameData/Mk2Expansion instead of U&hase87h/GameData/Mk2Expansion

@qm3ster qm3ster closed this Oct 8, 2015
@qm3ster qm3ster reopened this Oct 8, 2015
],
"suggests": [
{ "name": "FerramAerospaceResearch" }
],
"install" : [
{
"find" : "Mk2Expansion",
"find" : "GameData/Mk2Expansion",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need to use "GameData/Mk2Expansion", as find will ignore Mk2Expansion-1.6.06

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But not Mk2_Stock-a-like_Expansion-1.6.05.zip*Mk2Expansion*\GameData\Mk2Expansion
(1.6.05 was taken down not to break too many installs, but it might reoccur in the future)

@plague006
Copy link
Contributor

I hope /GameData/ doesn't become a file structure trend among mod creators. -_-

Merging with my thanks.

plague006 added a commit that referenced this pull request Oct 8, 2015
@plague006 plague006 merged commit 59b16e3 into KSP-CKAN:master Oct 8, 2015
@qm3ster qm3ster deleted the patch-1 branch October 8, 2015 08:41
@qm3ster
Copy link
Contributor Author

qm3ster commented Oct 8, 2015

Tbh I thought you hate me and will never merge anything ever again after I tried to merge 2 stupid things. BUT NOW I PULL HARD

@plague006
Copy link
Contributor

lol I always appreciate the help maintaining this mess of metadata.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants