Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notepad changes #271

Closed
wants to merge 2 commits into from
Closed

Notepad changes #271

wants to merge 2 commits into from

Conversation

monstrim
Copy link
Contributor

Had put a mod that was already here. Deleted the duplicate and changed the old from gitHub to KerbalStuff.

@pjf
Copy link
Member

pjf commented Dec 24, 2014

Travis says no due to a missing comma.

Also, this looks like we're renaming the mod identiifer, is that the case? If so, we really don't want to do that without good reason, as it means that CKAN will think it's a different mod, and will stop upgrading it, and any relationships that target it will become void. (Note that the identifier isn't shown to GUI uses at all, so you can change the name field as much and as often as you like without issue.)

@pjf pjf changed the title Patch 3 Notepad changes Dec 24, 2014
@monstrim
Copy link
Contributor Author

I originally uploaded a (KerbalStuff) mod with the identifier "Notepad" (uppercase N by mistake), but then noticed it was already uploaded, with the identifier "notes" and on GitHub. I'm attempting to delete the one I created, change the GitHub to KerbalStuff so it updates version automatically, and keep the "notes" identifier from the existing version.

On the GitHub/KerbalStuff change file, I deleted line 5 because NetKan parses the name from KerbalStuff, is that right?

It seems to me it's saying no because of the deleted file. The missing comma you mention comes before a deleted line, doesn't it?

"license" : "GPL-3.0",
"ksp_version" : "0.25",
"$kref" : "#/ckan/kerbalstuff/74",
"x_netkan_license_ok": true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The missing comma is here, at the end of this line :)

@Ippo343 Ippo343 mentioned this pull request Dec 25, 2014
@Ippo343 Ippo343 closed this in #312 Dec 25, 2014
SpaceTeph pushed a commit to SpaceTeph/NetKAN that referenced this pull request Jan 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants