Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Add B9PartSwitch to Kerbalism deps" #7111

Merged
merged 1 commit into from Apr 9, 2019
Merged

Revert "Add B9PartSwitch to Kerbalism deps" #7111

merged 1 commit into from Apr 9, 2019

Conversation

ghost
Copy link

@ghost ghost commented Apr 8, 2019

Reverts #7109

@DasSkelett
Copy link
Member

DasSkelett commented Apr 9, 2019 •
edited
Loading

Context: KSP-CKAN/CKAN-meta#1435

As soon as I merge this, the bot reruns and generates the 2.2.0 .ckan.
If I delete it afterwards, it will generate it in 4 hours again.

Can you delete the version from spacedock? This prevents the bot from pulling it.

@ghost
Copy link
Author

ghost commented Apr 9, 2019

Is there even a delete button on spacedock?

@DasSkelett
Copy link
Member

I think another option is to freeze the 2.2.0.ckan. Not sure if this works though.

@DasSkelett
Copy link
Member

DasSkelett commented Apr 9, 2019 •
edited
Loading

Is there even a delete button on spacedock?

Huh, no idea.

@DasSkelett
Copy link
Member

I'll try to freeze it.

DasSkelett added a commit to KSP-CKAN/CKAN-meta that referenced this pull request Apr 9, 2019
@DasSkelett
Freeze Kerbalism-2.2.0
33cbf20 
See #1435
and KSP-CKAN/NetKAN#7111
@DasSkelett DasSkelett mentioned this pull request Apr 9, 2019
Merged
DasSkelett added a commit to KSP-CKAN/CKAN-meta that referenced this pull request Apr 9, 2019
@DasSkelett
Freeze Kerbalism-2.2.0 (#1436)
927ad2f 
See #1435
and KSP-CKAN/NetKAN#7111
@DasSkelett
Copy link
Member

image
Worked!
So what about the dependency? For what version(s) do you want it added or removed?

@ghost
Copy link
Author

ghost commented Apr 9, 2019 •
edited by ghost
Loading

all of em. I added the dep too early -- SirMortimer thought it'd be needed due to a bug in the Configure module, but he found a different way to do things

@DasSkelett DasSkelett merged commit a71c95b into KSP-CKAN:master Apr 9, 2019
@ghost ghost deleted the revert-7109-patch-5 branch April 9, 2019 21:14
DasSkelett pushed a commit to DasSkelett/NetKAN that referenced this pull request May 25, 2019
@DasSkelett
Revert "Add B9PartSwitch to Kerbalism deps (KSP-CKAN#7109)" (KSP-CKAN…
2c9304f 
…#7111)

This reverts commit 9293507, reason: KSP-CKAN#7111 (comment)
ans removes B9PartSwitch from the dependencies again.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@DasSkelett