TextureReplacerReplaced should provide TextureReplacer #7149
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
If you try to install Astronomer's Visual Pack in CmdLine or GUI with KSP 1.3 through 1.7 marked as compatible, it'll prompt you to choose a TextureReplacer equivalent multiple times:
Cause
Originally, TRR provided TR, and all was good in the world. 0.5.1 and 0.5.2 were stamped with this metadata.
Then later, #6049 changed the netkan so TRR provided TRR instead of TR. This caused problems, and later #6068 removed the provides completely. 0.5.3 and 0.5.4 were stamped with this metadata.
So the end result is this in CKAN-meta:
For CmdLine and GUI, when they're asked to install TextureReplacer as a dependency, they notice that TRR provides it because of those older versions, but when they add it to the change set, they add the latest compatible version instead, which doesn't provide TR. So they ask again which TR-equivalent to install, and so on until something goes more wrong.
(ConsoleUI installs 0.5.2 as it should, but then allows you to upgrade TRR, which produces an inconsistent state.)
Changes
Now TRR provides TR as it originally did and should have all along.
Fixes part of KSP-CKAN/CKAN#2738.