Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Komplexity from SpaceDock #8656

Merged
merged 2 commits into from
Jul 29, 2021
Merged

Add Komplexity from SpaceDock #8656

merged 2 commits into from
Jul 29, 2021

Conversation

netkan-bot
Copy link
Member

@netkan-bot netkan-bot commented Jul 19, 2021

This pull request was automatically generated by SpaceDock on behalf of zer0Kerbal, to add Komplexity to CKAN.

Please direct questions about this pull request to zer0Kerbal.

Mod details:
Name = Komplexity
Author = zer0Kerbal
Abstract = KSC building levels increased to ten levels instead of the stock four. Doesn't add more building models.
License = GPLv2
Homepage = https://forum.kerbalspaceprogram.com/index.php?/topic/202749-*
Description =

Download on Curseforge or Github or SpaceDock. Also available on CKAN.

Komplexity (KPLX)

for Custom Barn Kit

by @zer0Kerbal

KSC building levels increased to ten levels instead of the stock four

Mod Version
KSP version KSP-AVC License GPLv2
Curseforge CKAN GitHub SpaceDock
Code Validate AVC .version files


Komplexity

Preamble

After playing KSP for a while, I wanted a tad more granularity to the building upgrades at the Kerbal Space Center. Stock's four levels (initial + three upgrades) just seemed too basic, and very unKerbalistic. So sat down with Bill and added some Komplexity and moar levels! yes, now there are a total of ten level (initial plus nine upgrades) for every building in the KSC (except currently the tracking station). This mod depends on ModuleManager and CustomBarnKit by @Sarbian.
Watch the video

VAB


SPH


Launch Pad


Runway


Astronaut Complex


Mission Control


Research and Development
Soil Samples available at level 4 R&D


Administration


Tracking Station


Notes:

* costs scale with game difficulty settings (as does stock) and the initial (level one) costs are in case you damage / destroy a building.

Installation Directions:

Changelog Summary

  • See ChangeLog for full details of mod changes

Known Issues

  • See Known Issues for full details of feature requests, and known issues

Dependencies

Recommends

Caveat Emptor:

Might conflict or have unintended consequences to combining

Suggests

Supports

Conflicts


red box below is a link to forum post on how to get support
How to get support

License

aka Legal Mumbo Jumbo

Source: GitHub
License: License GPLv2

*** All bundled mods are distributed under their own licenses***
*** All art assets (textures, models, animations) are distributed under their own licenses***

Original

Author: @zer0Kerbal
Thread
Download
Source: GitHub
License: License GPLv2

Be Kind: Lithobrake, not jakebrake! Keep your Module Manager up to date

v0.9.0.0 original: 01 Oct 2010 zed'K | updated: 10 May 2021 zed'K

ckan compat add 1.10 1.11 1.12

zer0Kerbal and others added 2 commits July 19, 2021 00:25
@HebaruSan
Copy link
Member

CustomBarnKit is marked as a dependency, but it is not getting installed or triggering an error. 😕

@DasSkelett
Copy link
Member

Wow, that's weird. Locally it works as it should, throwing an error without KSP KSP 1.11 & 1.10 marked as compatible, and succeeding with them marked compatible.
We must be hitting some weird edge case that I can't yet reproduce.

@zer0Kerbal
Copy link
Contributor

sorry for the inconvenience. 🍊 (just stumbled upon this issue)

@HebaruSan
Copy link
Member

HebaruSan commented Jul 29, 2021

sorry for the inconvenience. (just stumbled upon this issue)

No worries, this is a CKAN bug for us to figure out, not a problem with anything you've done. Hopefully we can resolve it soon and merge this.

Wow, that's weird. Locally it works as it should, throwing an error without KSP KSP 1.11 & 1.10 marked as compatible, and succeeding with them marked compatible.
We must be hitting some weird edge case that I can't yet reproduce.

I'm seeing the same. There's also a difference regarding KerbalChangelog, which is installed in the sandbox and not locally. Looks like it ought to be installed in both, as it's currently compatible with 1.9–1.11 and has no dependencies or conflicts.
Oh, oops, KCL is excluded from the change set because I already have (a dev copy of) it installed:

6559 [1] INFO CKAN.Registry (null) - Registering KerbalChangelog from GameData/KerbalChangelog/Plugins/KerbalChangelog.dll

🤦

@HebaruSan
Copy link
Member

Ohhhhhhh...

      "ksp_version_min": "1.4.5",
      "ksp_version_max": "1.12.9999",

The module's compatibility drives the input to ckan compat by default, so the dummy instance is built with compatibility enabled for KSP 1.4.5–1.12.9999.

CustomBarnKit-RO has compatibility with KSP 1.7.3:

https://github.com/KSP-CKAN/CKAN-meta/blob/26968cc3c0525965a617395b1f5b3bc798d98ced/CustomBarnKit-RO/CustomBarnKit-RO-1.1.20.0.ckan#L8

Both CustomBarnKit and CustomBarnKit-RO will be installable, so normally CKAN would prompt the user to choose. But the test runs with --headless, so we just skip this dependency. Everything is working fine! 😌

@HebaruSan HebaruSan merged commit bc63857 into master Jul 29, 2021
@HebaruSan HebaruSan deleted the add-Komplexity branch July 29, 2021 19:25
@HebaruSan
Copy link
Member

HebaruSan commented Jul 29, 2021

$ ../CKAN/_build/ckan.exe compat add 1.7
$ ../CKAN/_build/ckan.exe install -c Komplexity-0.9.3.0.ckan 
Too many mods provide CustomBarnKit. Please pick from the following:

1) CustomBarnKit-RO (Custom Barn Kit - RO build)
2) CustomBarnKit (Custom Barn Kit)
Enter a number between 1 and 2 (To cancel press "c" or "n".):

Yes, I see that this mod conflicts wtih CustomBarnKit-RO. That apparently comes into play downstream of the prompt rather than before it...

1
The following inconsistencies were found:
* CustomBarnKit-RO 1.1.20.0 conflicts with Komplexity 0.9.3.0
Install canceled. Your files have been returned to their initial state.

Finally, trying it with --headless:

$ ../CKAN/_build/ckan.exe install -c Komplexity-0.9.3.0.ckan --headless
About to install:

 * Komplexity 0.9.3.0 (cached)
 * Module Manager 4.1.4 (cached)
 * Kerbal Changelog v1.4.2 (cached)
Installing mod "Komplexity 0.9.3.0"
Installing mod "ModuleManager 4.1.4"
Installing mod "KerbalChangelog v1.4.2"
Updating registry
Committing filesystem changes
Done!

So that might be something we'd want to investigate as an opportunity for improving the relationship resolver.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants