-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue with locking steering and throttle when out of RT2 range #10
Comments
Thank you for your bug submission. Im going to be out for the next few days but when i get back this will be my top ticket! |
I am going to work on this tonight and this weekend. Too many are blocked from using the mod till we get this fixed. :P |
@marianoapp I have noticed we have a cfg file that we are trying to load from and i cant seem to find a copy of it for inclusion with the installer. Do you have this file? |
There's no need, the config file is automatically generated with default values on the first run. |
Groovy, Found it! thanks BTW do you use RemoteTech? |
Not yet, but I'm planning to in the future. I have a separated install of KSP with RT just to test the integration with kOS. |
@marianoapp cool. It feels pretty good when it works. @jwvanderbeck Did you have a good way to reproduce the remote tech bug we were having way back when? |
This bug is pretty evil. It exposes the fact that we really have two steering systems and if you try and use both they fight like two cats in a bag. The fix i have here makes it work but you can get into a bad state where you LOCK STEERING and then try to SET SHIP:CONTROL:ROLL TO -1. the fine control gets overwritten by the steering im tempted to ship this to see how it goes |
The solution might be to force the user to explicitly toggle which technique is in charge of the vessel, with a command, and put the two methods in an exclusive lockout relationship with each other, where they both share the same setting to decide "am I allowed to fly this thing?". Imagine this: When you issue this command: When you issue this command: A user could still mix and match the two techniques in the same program, but only by explicitly toggling between them, never by trying to have both on simultaneously. |
This is strange. The code that controls whether a program continues
On Sun, Apr 27, 2014 at 6:12 AM, Steven Mading notifications@github.comwrote:
|
@erendrake I think that solution is right as it would behave as if the user were pressing the steering keys. @jwvanderbeck The program executes just fine even when it's out of range but all the commands it gives to the craft are then overturned by RemoteTech. The steering issue is just something @erendrake found while fixing this. |
@jwvanderbeck sorry for the confusion i meant the bug where the RemoteTech API stuff was causing most of vessels to disappear. I couldn't find the original bug |
Ok so yeah this bug happens when RT2 is allowed to take over the vessel
On Mon, Apr 28, 2014 at 9:15 PM, Chris Woerz notifications@github.comwrote:
|
Pulling changes from the main repo
My program is copied to a local volume and then executed while still in range. It waits untill 60 seconds before ETA:APOAPSIS before turning off SAS and locking steering to prograde. Then 30 seconds before ETA:APOAPSIS it turns SAS on and locks throttle to 1. For some reason neither of the lock commands seem to work while out of range. SAS is toggled just fine and a visual aspect of the program continues to work.
The text was updated successfully, but these errors were encountered: