Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENGINE:VISP should return design vacuum ISP of the engine #273

Closed
pdbogen opened this issue Oct 15, 2014 · 4 comments
Closed

ENGINE:VISP should return design vacuum ISP of the engine #273

pdbogen opened this issue Oct 15, 2014 · 4 comments
Labels
enhancement Something new (not a bug fix) is being requested

Comments

@pdbogen
Copy link

pdbogen commented Oct 15, 2014

Ideally we'd have:
ENGINE:ISP:VACUUM
ENGINE:ISP:ATMOSPHERE
ENGINE:ISP:CURRENT

But I'm not sure if that would break compatibility with scripts expecting ENGINE:ISP to just be a number.

@Dunbaratu
Copy link
Member

It would break backward compatibility. In this case I don't think there is a good case for a separate ISP object because all it is is a plain scalar number. Having 3 different ISP's as flat numbers makes sense because they are indeed 3 different things.

Unlike, say, velocity, where Velocity:orbit and Velocity:surface are actually just two different ways to express the same exact thing - in two different frames of reference (come to think of it, we could also have a Velocity:target).

@pdbogen
Copy link
Author

pdbogen commented Oct 15, 2014

Works for me. P.S., VELOCITY:TARGET would save me a lot of LOCK RVEL TO VELOCITY:ORBIT - TARGET:VELOCITY:ORBIT.

On October 14, 2014 9:37:59 PM PDT, Steven Mading notifications@github.com wrote:

It would break backward compatibility. In this case I don't think
there is a good case for a separate ISP object because all it is is a
plain scalar number. Having 3 different ISP's as flat numbers makes
sense because they are indeed 3 different things.

Unlike, say, velocity, where Velocity:orbit and Velocity:surface are
actually just two different ways to express the same exact thing - in
two different frames of reference (come to think of it, we could also
have a Velocity:target).


Reply to this email directly or view it on GitHub:
#273 (comment)

  • Patrick

@erendrake
Copy link
Member

Question, what are you trying to do with these values?

@pdbogen
Copy link
Author

pdbogen commented Oct 15, 2014

For ENGINE:VISP, my intent was to calculate an upper bound for available DeltaV.

On October 14, 2014 11:57:23 PM PDT, Chris Woerz notifications@github.com wrote:

Question, what are you trying to do with these values?


Reply to this email directly or view it on GitHub:
#273 (comment)

  • Patrick

@erendrake erendrake modified the milestone: 0.16 Feature list Oct 19, 2014
@erendrake erendrake added the enhancement Something new (not a bug fix) is being requested label Feb 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Something new (not a bug fix) is being requested
Projects
None yet
Development

No branches or pull requests

3 participants