Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation footer does not list all contributors #714

Closed
erendrake opened this issue Apr 3, 2015 · 5 comments
Closed

Documentation footer does not list all contributors #714

erendrake opened this issue Apr 3, 2015 · 5 comments
Labels
documentation Change the Sphinx user documents.

Comments

@erendrake
Copy link
Member

currently we show

© Copyright 2014, Dunbaratu, erendrake, Originally By Nivekk.

I think that it should read

© Copyright 2014, Built by These People Originally By Nivekk.

Something like this would be great :)

@erendrake erendrake added the documentation Change the Sphinx user documents. label Apr 3, 2015
@erendrake erendrake added this to the v0.17.0 Punchlist milestone Apr 3, 2015
ZiwKerman added a commit to ZiwKerman/KOS that referenced this issue Apr 14, 2015
@ZiwKerman ZiwKerman mentioned this issue Apr 14, 2015
@ZiwKerman
Copy link
Contributor

This is fixed now BTW

@Dunbaratu
Copy link
Member

This is not entirely fixed.

In develop branch, I get this error from 'make html' :

checking consistency... /Users/madings/KOS-1/doc/source/copyright.rst:: WARNING: document isn't included in any toctree
/Users/madings/KOS-1/doc/source/tutorials/exenode.rst:: WARNING: document isn't included in any toctree
done

What this means is that although the file copyright.rst exists, none of the other pages refer to it from anywhere. (maybe your commit was missing one of the edits?).

@Dunbaratu
Copy link
Member

It should probably replace about.rst.

@Dunbaratu
Copy link
Member

Also, the link https://github.com/orgs/KSP-KOS/people doesn't mention TDW89, when linked to from outside.

(edit: I think that's because of the privacy settings though so that's okay - the people being hidden from the list are the ones with the private setting on - so never mind).

@ZiwKerman
Copy link
Contributor

Thing with copyright.rst is that it is hardcoded into sphinx-rtd-theme and does not require linking anywhere in the docs themselves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Change the Sphinx user documents.
Projects
None yet
Development

No branches or pull requests

3 participants