Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runing programs from inside functions #732

Closed
abenkovskii opened this issue Apr 4, 2015 · 4 comments
Closed

runing programs from inside functions #732

abenkovskii opened this issue Apr 4, 2015 · 4 comments
Assignees
@Dunbaratu
Milestone
v0.17.0 Punchlist

Comments

@abenkovskii
Copy link
Contributor

exception
log: http://pastebin.com/Yie6RS6n
@abenkovskii abenkovskii mentioned this issue Apr 4, 2015
Closed
@abenkovskii abenkovskii changed the title run ing from inside function s. runing programs from inside function s. Apr 4, 2015
@abenkovskii
Copy link
Contributor Author

screenshot4
and from a program it just does not invoke at all.

@Dunbaratu
Copy link
Member

Hmm.... can you try again, but this time put empty parentheses on the function call both from interpreter and from program?

hello1().

run_hello().

I think that may be related to the bug, but this test would help prove if it was.

@abenkovskii
Copy link
Contributor Author

From console: no difference
screenshot1
From program: all the same
screenshot3

@Dunbaratu Dunbaratu self-assigned this Apr 5, 2015
@Dunbaratu Dunbaratu added this to the v0.17.0 Punchlist milestone Apr 5, 2015
@abenkovskii abenkovskii mentioned this issue Apr 5, 2015
Closed
@abenkovskii abenkovskii changed the title runing programs from inside function s. runing programs from inside functions. Apr 5, 2015
@abenkovskii abenkovskii changed the title runing programs from inside functions. runing programs from inside functions Apr 5, 2015
Dunbaratu added a commit to Dunbaratu/KOS-1 that referenced this issue Apr 9, 2015
@Dunbaratu
Resolves KSP-KOS#732 and Resolves KSP-KOS#746. function bodies prepar…
5b0763f 
…se now.

Function bodies previously didn't get preparsed for triggers
properly.  Now it recurses down into themto ensure it finds
the triggers inside.  This fixes both the problems
because RUN and WHEN are both in need of a preprocess pass to
work properly, and it was the lack of that preprocess pass that
was causing the problem in both these cases.
@abenkovskii
Copy link
Contributor Author

@Dunbaratu Thank you a lot! Now I'm finally able to merge my exec.ks and run_by_name_.ks into utils.ks.
P.S. I even thought of manually making a file _utils__exec.ksm that creates a function exec(command) when you import (run) it.

@erendrake erendrake mentioned this issue Apr 14, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Dunbaratu Dunbaratu

Labels
None yet
Projects
None yet
Milestone
v0.17.0 Punchlist
Development

No branches or pull requests
2 participants
@Dunbaratu @abenkovskii