Parameters are passed in reverse order

[tsbockman]

The parameter list of a script is passed to it backwards. Example script test.txt:

declare parameter p0.
declare parameter p1.
declare parameter p2.
declare parameter p3.

print "0: " + p0.
print "1: " + p1.
print "2: " + p2.
print "3: " + p3.

Call it from the terminal as follows:

run test(0, 1, 2, 3).

The expected result would be:

0: 0
1: 1
2: 2
3: 3

But, the actual result is:

0: 3
1: 2
2: 1
3: 0

I believe this bug also effects some or all built-in functions (but not constructors):

print mod(21, 6).

According to the documentation, this command should return 3. However, it actually returns 6. But, it gives the expected answer if we flip the parameters:

print mod(6, 21).

[marianoapp]

Parameters must be popped in reverse order since the first parameter is deeper in the stack. It worked fine when multiple parameters were declared in the same statement, but for more than one statement it didn't know which one was the last.
Now it scan the whole AST looking for parameters and adds them to a list, and when it finish they're pushed in the correct order.
An interesting side effect of the solution is that the declaration of parameters no longer need to be the first line of the program, in fact, you can write them any where you want.

Edit: Also fixed the MOD function parameter order, although that was an unrelated problem.

[tsbockman]

Thanks! All the work you guys put into this mod is much appreciated.

Also, I never even knew I could do this:

declare parameter p0, p1, p2, p3.

Much easier! I guess I was the first to notice this bug because everyone else uses the better syntax...

[Dunbaratu]

No I use your syntax too, because I want to put comments explaining the parameters in the code.

[tsbockman]

@Dunbaratu How about something like this?

declare parameter
 p0, // Comment 0
 p1, // Comment 1
 p2, // Comment 2
 p3. // Comment 3

That way you can comment each parameter, while being more concise and DRY.

[Dunbaratu]

The older parsers were very finicky and didn't like putting comments like that in the middle of multi-line syntax.