KSP 1.4 compatibility: #2241
Merged
KSP 1.4 compatibility: #2241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0 - To compile this, remember to drop in the new dll's from KSP 1.4 into your Resources first. 1 - Unity dropped the WWW.audioClip method and obsoleted it. SQUAD apparently added an extension method to WWW called WWW.GetAudioClip() that does the same thing and works. 2 - SQUAD added a new type: HsvColor, in the root namespace, that masked our own HsvColor class. Rather than using "using" statements or explicit namespaces, I renamed our HsvColor to HsvaColor, since technically that is a better name that matches up with our RgbaColor class.
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2240
0 - To compile this, remember to drop in the new dll's from
KSP 1.4 into your Resources first.
1 - Unity dropped the WWW.audioClip method and obsoleted it.
SQUAD apparently added an extension method to WWW called
WWW.GetAudioClip() that does the same thing and works.
2 - SQUAD added a new type: HsvColor, in the root namespace,
that masked our own HsvColor class. Rather than using "using"
statements or explicit namespaces, I renamed our HsvColor to
HsvaColor, since technically that is a better name that matches
up with our RgbaColor class.