Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #2283 Mission Builder boot system #2292

Merged
merged 1 commit into from Jun 10, 2018
Merged

Fixes #2283 Mission Builder boot system #2292

merged 1 commit into from Jun 10, 2018

Conversation

lucaelin
Copy link
Contributor

@lucaelin lucaelin commented Jun 6, 2018

Don't require a vessel to be in PRELAUNCH situation for a bootfile to be copied to the vessels HardDisk.
This fixes #2283

Don't require a vessel to be in PRELAUNCH situation for a bootfile to be copied to the vessels HardDist
@lucaelin lucaelin changed the title Fixes #2283 Fixes #2283 Mission Builder boot system Jun 6, 2018
@Dunbaratu
Copy link
Member

I tested this and it didn't seem to fix the base problem so I guess it requires more than I thought.

This is the test it fails:

  • In Mission Builder, make a tiny mission that only has the one start node and nothing else. Make that start node spawn a vessel on the launchpad, that you create in the mission builder. When making the vessel in the VAB, assign a simple boot script to it that just does print "IF YOU SEE THIS, I AM RUNNING THE BOOT SCRIPT."..
  • Test the mission. It appears to work and the boot script gets copied to the vessel and runs.
  • Quit the test and go back to the Mission Builder.
  • In the MIssion Builder, change the vessel spawn so it now spawns in orbit instead of on the launchpad.
  • Test the mission again.
  • Now the boot script does NOT copy to the vessel, and does NOT run.

So I must have been wrong about assuming it would be fixed just by removing the PRELAUNCH check. There's got to be something more to it.

@Dunbaratu Dunbaratu merged commit 07d5e70 into KSP-KOS:develop Jun 10, 2018
@Dunbaratu
Copy link
Member

Dunbaratu commented Jun 10, 2018

I couldn't re-create the problem mentioned above when I tried again later. I don't know why.
Whatever the case is, this PR doesn't make the problem any worse, or introduce any new problems, so I feel okay merging it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DLC's Mission Builder breaks the boot system
2 participants