Implemented TriggerAU's suggested fix to range limit #2554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dunbaratu
commented
Jun 25, 2019
| { | ||
| // I have no clue what this actually looks like in the UI? What is a | ||
| // user editable 2-D vector widget? I've never seen this before. | ||
| if (convertedVal != null) |
There was a problem hiding this comment.
The above looks like a large edit, but if you look carefully, all it is is just a change of indent level.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2531
I got some feedback from SQUAD team member TriggerAU about this problem and he pointed me to the API call that SQUAD uses to obtain the float ranges, and it encapsulates some of the work needed to find the cases where a float range is getting overridden by another float range. This method call TryGetFieldUIControl seems to do everything right and obtain the true ranges that game is actually using.