Added Fixedupdate Handler #617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| private readonly Dictionary<IUpdateObserver, int> observers = new Dictionary<IUpdateObserver, int>(); | ||
|
|
||
| private readonly HashSet<IUpdateObserver> observers = new HashSet<IUpdateObserver>(); | ||
| private readonly HashSet<IUpdateObserver> fixedObservers = new HashSet<IUpdateObserver>(); |
There was a problem hiding this comment.
I am assuming you were using a dictionary before to Assert a unique constraint? A hashset should do the same without throwing an exception :)
There was a problem hiding this comment.
I was searching the .net docs for something like a hash and could't find it and gave up and used Dictionary.
|
Looks good. Now that this is here we can seriously consider what happens if we move CPU update to fixedupdate (or just try it and see what happens). Once we do that step, we'll have to dig through a lot of the docs and make sure they stop talking about stuff happening during Update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is ready to be merged