Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added grey #627

Merged
merged 1 commit into from
Mar 3, 2015
Merged

added grey #627

merged 1 commit into from
Mar 3, 2015

Conversation

erendrake
Copy link
Member

there is no issue for this, this class talks about GRAY as an alternative spelling but we didnt actually have the alternative?

@Dunbaratu
Copy link
Member

it may be a good idea to alias both spellings - GREY and GRAY.
by the way this doesn't have the 'ready to merge' label, which is why I'm leaving it - not because of the alias thing.

@erendrake
Copy link
Member Author

I should have marked it with discussion. I am ambivalent about adding both spellings i just wanted to bring it up. It is ready to merge :)

Dunbaratu added a commit that referenced this pull request Mar 3, 2015
@Dunbaratu Dunbaratu merged commit 4684145 into KSP-KOS:develop Mar 3, 2015
@erendrake erendrake deleted the add_grey branch March 21, 2015 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants