Fixes #694 by moving the for loop's code around a bit. #695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| AddOpcode(new OpcodePush(iteratorIdentifier)); | ||
| AddOpcode(new OpcodeUnset()); | ||
| VisitVariableNode(node.Nodes[1]); | ||
| AddOpcode(new OpcodeUnset()); |
There was a problem hiding this comment.
This code made sense when variables were all global.. But now, there's no point in doing cleanup on it when it's about to go out of scope on the very next instruction, and get orphaned away.
Dunbaratu
changed the title
Dunbaratu
added
bug
erendrake
added a commit
that referenced
this pull request
Mar 31, 2015
Fixes #694 by moving the for loop's code around a bit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.