Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lunar Snowball Nerf #1418

Merged
merged 16 commits into from Apr 14, 2021
Merged

Conversation

StonesmileGit
Copy link
Member

Implements the suggested changes in #1370, section 1. Lander revamp is to come.

Feedback about values or implementation is very welcome!

Reduced the number of completions from 2 to 1. Rewards are currently the same as previously.
replaced some spaces with tabs and removed unneccessary tabs at ends of lines.
Lowered the payout on later Lunar Impact missions by introducing arrays containing the payouts.
Lowered the payout on the second Lunar Orbiter mission by introducing arrays containing the payouts.
Arrays were also added to hold the apsis, but with placeholder values
@StonesmileGit
Copy link
Member Author

Sample return and rovers might also get some attention.

Added far side lander contract with 2 completions.
Currently set to same payout as the two Orbiter contracts.
Contract currently becomes available after 2 completions of the normal landing contract.
Reduced number of normal landers contracts by 1.
Lowered the payout for later missions by introducing arrays containing the payouts.
Changed max Aposelene on first 'Lunar Orbiter' contract to 3 000 km and fixed a typo in 'Lunar Lander Far Side' description
@siimav siimav marked this pull request as ready for review December 24, 2020 15:06
@siimav siimav marked this pull request as draft December 24, 2020 15:07
showMessages = true
disableOnStateChange = false
}
PARAMETER
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A possible thing to consider here is to require all parameters to be completed in sequence. This way the contract could be completed with the help of a relay or alternatively by launching the lander into orbit again.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be solved with the latest commit, but not sure

GameData/RP-0/Contracts/Moon Exploration/Lunar Flyby.cfg Outdated Show resolved Hide resolved
Adds the longitude of the Alpha landing site to the contract to let players know where the contract wants you to land.
Deleted unused DATA node in Lunar Flyby, removed useless requirement on far side lander, made the two lander contracts unable to be accepted at the same time and hopefully prevented another vessel from completing parts of 'Far Side Lander' contract.
@StonesmileGit
Copy link
Member Author

The payout for the new 'Far Side Lunar Lander' contract might need to be updated, since they are copied from another contract currently.
However, I have no idea what reasonable numbers are and would like some input.

@StonesmileGit
Copy link
Member Author

@siimav Could you take a look when you have some time over?

@StonesmileGit StonesmileGit marked this pull request as ready for review December 26, 2020 21:47
@siimav
Copy link
Contributor

siimav commented Jan 1, 2021

A few of the REQUIREMENT indentations appear to be off by 1 level

Remove REQUIREMENT to have NOT completed 'Moon Boots'
Added calculations to display latitude of the landing site and make the location show magnitude instead of negative western/southern locations.
@leudaimon
Copy link
Contributor

I'm currently testing these (might take some time to make through them in-career to check the rewards and so on.
Regarding the flyby contract. I think it's necessary to add in the description that it has a single completion, especially because the others mention the number of completions.

@siimav
Copy link
Contributor

siimav commented Apr 14, 2021

I think the only thing preventing this from getting merged is the point @leudaimon brought up about the orbiter contract max Ap requirements. Do others feel that 500km for second completion is fair or should we try to strike a middle ground between that and what we have now?

@lpgagnon
Copy link
Contributor

500km doesn't seem unreasonable; but a quick look at historical missions suggests such a low Ap is fairly unusual.

I wonder if requiring a higher Pe might make sense? Min 20km isn't much of a constraint.

@StonesmileGit
Copy link
Member Author

If the Pe isn't going to be changed, then this should be mostly done; if something else should be changed, let me know

@siimav siimav changed the base branch from master to MidgameRebalance April 14, 2021 21:25
@siimav siimav merged commit ee12e8c into KSP-RO:MidgameRebalance Apr 14, 2021
@StonesmileGit StonesmileGit deleted the LunarContracts branch April 20, 2021 12:53
siimav pushed a commit that referenced this pull request Apr 30, 2021
NathanKell pushed a commit that referenced this pull request May 14, 2021
NathanKell pushed a commit that referenced this pull request May 18, 2021
NathanKell pushed a commit that referenced this pull request May 22, 2021
NathanKell pushed a commit that referenced this pull request May 24, 2021
NathanKell pushed a commit that referenced this pull request May 24, 2021
NathanKell pushed a commit that referenced this pull request May 25, 2021
siimav pushed a commit that referenced this pull request May 27, 2021
NathanKell pushed a commit that referenced this pull request May 29, 2021
NathanKell pushed a commit that referenced this pull request May 30, 2021
NathanKell pushed a commit that referenced this pull request May 31, 2021
NathanKell pushed a commit that referenced this pull request Jun 3, 2021
NathanKell pushed a commit that referenced this pull request Jun 5, 2021
siimav pushed a commit that referenced this pull request Jun 22, 2021
siimav pushed a commit that referenced this pull request Jun 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants