Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added a ModuleScienceContainer to ProcAvi, as well as range safety #637

Merged
merged 4 commits into from
Apr 3, 2017
Merged

Added a ModuleScienceContainer to ProcAvi, as well as range safety #637

merged 4 commits into from
Apr 3, 2017

Conversation

rsparkyc
Copy link
Member

@rsparkyc rsparkyc commented Apr 3, 2017

Fixes #635

@pjf pjf added the in progress label Apr 3, 2017
ec429
ec429 reviewed Apr 3, 2017
View reviewed changes
GameData/RP-0/ProceduralAvionics.cfg Outdated
@@ -81,6 +86,15 @@

MODULE
{
name = ModuleScienceContainer
reviewActionName = Review Stored Data
storeActionName = Stored Expirements
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not "Experiments"?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow, good catch

@rsparkyc
Copy link
Member Author

rsparkyc commented Apr 3, 2017

Latest merge also fixes the NRE mentioned is #636, though there's still something weird going on with FASA there

@rsparkyc rsparkyc merged commit 67708b0 into KSP-RO:master Apr 3, 2017
@pjf pjf removed the in progress label Apr 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ec429 ec429 ec429 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rsparkyc @ec429 @pjf