Basic support for CarnationRED Flexible Parts #2424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- extract proctanks "set availableTypes" into reuable helper - configure the core CRFP part to expose the classic Default/Fuselage/etc realfuel tank types - add additional parts corresponding to procparts Conventional, Integral, etc types For cylinders, dry mass and available volume seem to match procparts equivalents in all cases. For more exotic shapes, we get what we get. One omission: a pure, tankless "structural" part. Not a priority, and couldn't quite see how to use this to configure mass scaling: https://github.com/CarnationRED/CarnationREDFlexibleParts/blob/c5bad4fa060b07ff6dc0cd3bcd126acd0ddede2a/Main/ModuleCarnationVariablePart.cs#L809-L810
For parity with ROTanks, and because why not
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default/Fuselage/etc realfuel tank types
Integral, etc types
For cylinders, dry mass and available volume seem to match procparts
equivalents in all cases. For more exotic shapes, we get what we get.
One omission: a pure, tankless "structural" part. Not a priority,
and couldn't quite see how to use this to configure mass scaling:
https://github.com/CarnationRED/CarnationREDFlexibleParts/blob/c5bad4fa060b07ff6dc0cd3bcd126acd0ddede2a/Main/ModuleCarnationVariablePart.cs#L809-L810