Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin page fixes #288

Merged
merged 1 commit into from Jun 24, 2020
Merged

Admin page fixes #288

merged 1 commit into from Jun 24, 2020

Conversation

HebaruSan
Copy link
Contributor

This pull request attempts to make the admin pages somewhat usable.

Problems Changes
The admin page's tabstrip contains Users, Blog, Publishers, Games, Game Versions, E-Mail, Links. The positioning of Blog is weird because it's in the middle of a bunch of record-editing tools, and far away from its fellow communication tool E-Mail. Now the record editors are at the left and the communications tools are afterwards: Users, Publishers, Games, Game Versions, Blog, E-Mail, Links
If you search for a Publisher, Game, or Game Version and no matches are returned... image ... a pagination button is shown even though there's nothing to paginate, the section heading overlaps the pagination button, and the error message implies that no records exist and modders can't create mods. Now the pagination buttons only show up when the record list is non-empty, the section heading has sufficient space, and the message simply says there were no matches. image
If you click the button to create a Publisher, Game, or Game Version without filling in all the fields, it redirects to /asdf. If you try to create a duplicate, it redirects to /fdsa. Now an explanatory error message is shown without redirecting somewhere else, so you can try again. image
You can't create the same game version for two different games. E.g., if KSP has "1.0", the admin page will consider that a duplicate if you try to create "1.0" for Balsa. Now the duplicate check is per-game.
The search label for Game Versions says "Search games" Now it says "Search game versions"
The Publisher and Game tables each contain a Link column which mostly contains invalid links to 'None' Now these aren't rendered as links if they're None
The admin page's template loads the script file for mod creation. This is not needed and possibly dangerous since it could run unintended code. Now this is removed.
If you create a Game, it will not be marked as active. Someone will have to go into the SQL for you and do it with code. Now newly created Games are set to active=True.

@HebaruSan HebaruSan added Type: Improvement Priority: Low Status: Ready Area: Frontend Related to HTML, JS, CSS, or other browser things labels Jun 24, 2020
@HebaruSan HebaruSan merged commit 4161440 into KSP-SpaceDock:alpha Jun 24, 2020
@HebaruSan HebaruSan deleted the fix/admin branch June 24, 2020 19:19
This was referenced Jun 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Frontend Related to HTML, JS, CSS, or other browser things Priority: Low Status: Ready Type: Improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants