-
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User profile fields for KerbalX and GitHub #381
User profile fields for KerbalX and GitHub #381
Conversation
I think it's time to differentiate between fields where only the username is required (Twitter, Reddit, GitHub, KerbalX), and where the complete link is required (KSP Forums), on the edit page. I've seen many profiles where the links are messed up because they put the complete link where only a username should be put into. Maybe by appending |
Agreed. How about some client side validation? When the user tries to save, we could inspect the fields and raise an alert if any of them are formatted wrong. |
Sounds good. We don't need to do a full URL parsing, checking if it begins with |
OK, renamed the labels to include either "link" or "username" and added some validation.
|
8274ecd
to
d318595
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rebased on alpha after #380
Looks good!
Motivation
The profile currently allows the user to enter their username on the KSP forum, Twitter, Reddit, and IRC. I think GitHub is more important for modders, and KerbalX is more important for a lot of non-modders.
Changes
Now the profile has KerbalX and GitHub fields.
Note that this will need to be rebased if #380 is merged first, or vice versa, since both have migrations with the same down revision.