Fix issue #154 : Copied part for drag cube generation must be renamed…

… with the "Drag Rendering Clone" substring in order to have proper cleanup done by the Vessel.OnDestroy() method.
KSPModdingLibs · Sep 13, 2023 · bacedf3 · bacedf3
1 parent ec6cc91
commit bacedf3
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/KSPCommunityFixes/Performance/DragCubeGeneration.cs b/KSPCommunityFixes/Performance/DragCubeGeneration.cs
@@ -230,7 +230,7 @@ public static IEnumerator RenderDragCubesCoroutine(Part part, ConfigNode dragCon
         public static IEnumerator RenderDragCubesOnCopy(Part originalPart, DragCubeList dragCubeList, ConfigNode dragConfig)
         {
             if (originalPart.frozen)
-                Debug.LogWarning($"[KSPCF/DragCubeGeneration] Generating drag cubes on detached part ({originalPart.partInfo.name}) in the editor isn't supported and might give incorrect results.");
+                Debug.LogWarning($"[KSPCF/DragCubeGeneration] Generating drag cubes on detached part ({originalPart.partInfo.name}) in the editor isn't supported and will give incorrect results.");
 
             int childCount = originalPart.children.Count;
             if (childCount > 0)
@@ -284,6 +284,8 @@ public static IEnumerator RenderDragCubesOnCopy(Part originalPart, DragCubeList
             }
 
             GameObject partObject = part.gameObject;
+            // fix issue #154 : that substring in the name is actually checked in the Vessel.OnDestroy() method, doing a bunch of cleanup...
+            partObject.name += " Drag Rendering Clone"; 
             partObject.SetActive(true);
 
             ModuleJettison moduleJettison = null;
@@ -496,7 +498,7 @@ public static IEnumerator RenderDragCubesOnCopy(Part originalPart, DragCubeList
         public static DragCube RenderDragCubeImmediate(Part part, string dragCubeName)
         {
             if (part.frozen)
-                Debug.LogWarning($"[KSPCF/DragCubeGeneration] Generating drag cubes on detached part ({part.partInfo.name}) in the editor isn't supported and might give incorrect results.");
+                Debug.LogWarning($"[KSPCF/DragCubeGeneration] Generating drag cubes on detached part ({part.partInfo.name}) in the editor isn't supported and will give incorrect results.");
 
             DragCube dragCube = new DragCube(dragCubeName);