Vessel effects audio have a pos/rot offset in KSP 1.12 #42
Labels
kspBug
Identified KSP issue
Comments
gotmachine
added a commit
that referenced
this issue
Jun 8, 2022
…ned with the current vessel after scene switches, causing loss of vessel effects audio and random volume or left/right channel weirdness. Thanks to @ensou04 for uncovering the cause of this bug.
gotmachine
added a commit
that referenced
this issue
Jan 30, 2023
…ned with the current vessel after scene switches, causing loss of vessel effects audio and random volume or left/right channel weirdness. Thanks to @ensou04 for uncovering the cause of this bug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This causes random audio loss and L/R channel weirdness.
Issue uncovered by @ensou04
See forum post
The issue seems to be in the
FlightCamera.EnableCamera()andFlightCamera.DisableCamera()methods.They are re-parenting the
AudioListenerGameObjectusing theTransform.SetParent(Transform parent)overload that set theworldPositionStaysparameter to true, which will induce a local position/rotation offset when reparenting.Patching those methods to use the
Transform.SetParent(Transform parent, bool worldPositionStays)overload with that last parameter set to false should prevent any offset to ever be introduced.Test build with a fix :
KSPCommunityFixes_1.15.0_PRERELEASE.zip
The text was updated successfully, but these errors were encountered: