Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Engine plate decouplers cause the top-attached part to be shielded from airstream #52

Closed
gotmachine opened this issue Jul 2, 2022 · 0 comments
Labels
kspBug Identified KSP issue

Comments

@gotmachine
Copy link
Contributor

ModuleDecouple on engine plates is setting all attached parts as "shielded from airstream", excepted the part attached to the node defined in the bottomNodeName of the ModuleJettison module.

The intent is to disable drag (as well as some interactions like deploying animated parts) on all other node-attached parts, but "all other node-attached parts" will also typically include the part attached to the engine plate top node, which is clearly an unwanted oversight.

Fundamentally, ModuleDecouple is missing a way to define exclusions or inclusions for airstream-shielded nodes in its config. Implementing such a config option is difficult and would require concrete patches for every stock and modded part using isEnginePlate = true.

Alternatively, we can use some heuristics to determine which nodes should be excluded. For all stock engine plates, excluding nodes with id = "top" would work, but there is no guarantee this would hold true with modded parts.

Another heuristic would be to exclude all nodes whose orientation is significantly different than the node identified by the bottomNodeName of the ModuleJettison module. This might fail in case of a complex modded part setup, but as of writing a quick github search show no potential issue.

@gotmachine gotmachine added the kspBug Identified KSP issue label Jul 2, 2022
gotmachine added a commit that referenced this issue Jul 2, 2022
- New KSP bugfix : [EnginePlateAirstreamShieldedTopPart](#52) (Thanks to @yalov (flart) for reporting and to @Aelfhe1m for coming up with a clever solution).
- New KSP bugfix : [AsteroidInfiniteMining](#51) (Thanks to @Rodg88 for reporting).
gotmachine added a commit that referenced this issue Jan 30, 2023
- New KSP bugfix : [EnginePlateAirstreamShieldedTopPart](#52) (Thanks to @yalov (flart) for reporting and to @Aelfhe1m for coming up with a clever solution).
- New KSP bugfix : [AsteroidInfiniteMining](#51) (Thanks to @Rodg88 for reporting).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kspBug Identified KSP issue
Development

No branches or pull requests

1 participant