More memory leaks #215
Merged
More memory leaks #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s from mods (there was one in KOS)
gotmachine
reviewed
Apr 4, 2024
Comment on lines
+797
to
+798
| FlightGlobals.ResetObjectPartUpwardsCache(); | ||
| FlightGlobals.ResetObjectPartPointerUpwardsCache(); |
There was a problem hiding this comment.
Not ideal to reset that cache here since that will often cause it to be immediately rebuilt in every case a debris or another vessel gets out of loading range. Ideally we could be a bit smarter by waiting for next frame and only removing destroyed parts from those caches, but probably not worth the trouble, and I agree this is a potentially quite bad leak.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.