Potential fix for issue #216 #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Optimization of raycasts in ModuleEngines.EngineExhaustDamage() and ModuleDeployableSolarPanel.CalculateTrackingLOS() : - Only synchronize transforms on the first raycast from any module, mainly relevant when something else is moving transforms in between calls, which is often the case for active engines with gimbals. - Cached ScaledSpace raycast results for solar panels : call time is divided by between 4 (when blocked by a scaled space object) and 2 (when not blocked)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimization of raycasts in
ModuleEngines.EngineExhaustDamage()andModuleDeployableSolarPanel.CalculateTrackingLOS():ModuleEngines.FixedUpdate()when engines are actively gimballing (which is almost always the case as long as the SAS is activated)ModuleDeployableSolarPanel.FixedUpdate()call time is divided by between 4 (when blocked by a scaled space object) and 2 (when not blocked)On a side note, it seems there are some unrelated optimizations opportunities in
ModuleDeployablePart.FixedUpdate()(which is the base class of solar panels, also shared by radiators and antennas), as when profiling (static) solar panels, the bulk of the call time was spent there doing more or less nothing. I suspect continuously (and uselessly) setting the drag cube weights is in large part responsible.