Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable -Wcast-function-type globally #20

Closed
kees opened this issue Nov 15, 2019 · 9 comments
Closed

Enable -Wcast-function-type globally #20

kees opened this issue Nov 15, 2019 · 9 comments
Assignees
@GustavoARSilva
Labels
[Build] Global flag [Feature] CFI Involves Control Flow Integrity good first issue Good for newcomers [Linux] v5.17 Released in Linux kernel v5.17

Comments

@kees
Copy link

kees commented Nov 15, 2019

In order to make sure new function cast mismatches are not introduced in the kernel (to avoid tripping CFI checking), the kernel should be globally built with -Wcast-function-type. Many call sites need to be fixed before this can happen.
@kees kees added the good first issue Good for newcomers label Nov 15, 2019
@kees
Copy link
Author

kees commented Nov 15, 2019 •
edited

Excluding the fixes being developed for crypto, bnx2x, and staging/rtl*, the remaining 23 cases found with an x86_64 allmodconfig build are:

./include/linux/filter.h:344:4: warning: cast between incompatible function types from ‘unsigned int (*)(const void *, const struct bpf_insn *)’ to ‘u64 (*)(u64,  u64,  u64,  u64,  u64)’ {aka ‘long long unsigned int (*)(long long unsigned int,  long long unsigned int,  long long unsigned int,  long long unsigned int,  long long unsigned int)’} [-Wcast-function-type]
kernel/bpf/verifier.c:8928:16: note: in expansion of macro ‘BPF_CAST_CALL’
./include/linux/filter.h:344:4: warning: cast between incompatible function types from ‘void * (* const)(struct bpf_map *, void *)’ to ‘u64 (*)(u64,  u64,  u64,  u64,  u64)’ {aka ‘long long unsigned int (*)(long long unsigned int,  long long unsigned int,  long long unsigned int,  long long unsigned int,  long long unsigned int)’} [-Wcast-function-type]
kernel/bpf/verifier.c:9281:17: note: in expansion of macro ‘BPF_CAST_CALL’
./include/linux/filter.h:344:4: warning: cast between incompatible function types from ‘int (* const)(struct bpf_map *, void *, void *, u64)’ {aka ‘int (* const)(struct bpf_map *, void *, void *, long long unsigned int)’} to ‘u64 (*)(u64,  u64,  u64,  u64,  u64)’ {aka ‘long long unsigned int (*)(long long unsigned int,  long long unsigned int,  long long unsigned int,  long long unsigned int,  long long unsigned int)’} [-Wcast-function-type]
kernel/bpf/verifier.c:9285:17: note: in expansion of macro ‘BPF_CAST_CALL’
./include/linux/filter.h:344:4: warning: cast between incompatible function types from ‘int (* const)(struct bpf_map *, void *)’ to ‘u64 (*)(u64,  u64,  u64,  u64,  u64)’ {aka ‘long long unsigned int (*)(long long unsigned int,  long long unsigned int,  long long unsigned int,  long long unsigned int,  long long unsigned int)’} [-Wcast-function-type]
kernel/bpf/verifier.c:9289:17: note: in expansion of macro ‘BPF_CAST_CALL’
./include/linux/filter.h:344:4: warning: cast between incompatible function types from ‘int (* const)(struct bpf_map *, void *, u64)’ {aka ‘int (* const)(struct bpf_map *, void *, long long unsigned int)’} to ‘u64 (*)(u64,  u64,  u64,  u64,  u64)’ {aka ‘long long unsigned int (*)(long long unsigned int,  long long unsigned int,  long long unsigned int,  long long unsigned int,  long long unsigned int)’} [-Wcast-function-type]
kernel/bpf/verifier.c:9293:17: note: in expansion of macro ‘BPF_CAST_CALL’
./include/linux/filter.h:344:4: warning: cast between incompatible function types from ‘int (* const)(struct bpf_map *, void *)’ to ‘u64 (*)(u64,  u64,  u64,  u64,  u64)’ {aka ‘long long unsigned int (*)(long long unsigned int,  long long unsigned int,  long long unsigned int,  long long unsigned int,  long long unsigned int)’} [-Wcast-function-type]
kernel/bpf/verifier.c:9297:17: note: in expansion of macro ‘BPF_CAST_CALL’
./include/linux/filter.h:344:4: warning: cast between incompatible function types from ‘int (* const)(struct bpf_map *, void *)’ to ‘u64 (*)(u64,  u64,  u64,  u64,  u64)’ {aka ‘long long unsigned int (*)(long long unsigned int,  long long unsigned int,  long long unsigned int,  long long unsigned int,  long long unsigned int)’} [-Wcast-function-type]
kernel/bpf/verifier.c:9301:17: note: in expansion of macro ‘BPF_CAST_CALL’
./include/linux/filter.h:344:4: warning: cast between incompatible function types from ‘void * (*)(struct bpf_map *, void *)’ to ‘u64 (*)(u64,  u64,  u64,  u64,  u64)’ {aka ‘long long unsigned int (*)(long long unsigned int,  long long unsigned int,  long long unsigned int,  long long unsigned int,  long long unsigned int)’} [-Wcast-function-type]
./include/linux/filter.h:352:14: note: in definition of macro ‘BPF_EMIT_CALL’
kernel/bpf/hashtab.c:510:26: note: in expansion of macro ‘BPF_CAST_CALL’
./include/linux/filter.h:344:4: warning: cast between incompatible function types from ‘void * (*)(struct bpf_map *, void *)’ to ‘u64 (*)(u64,  u64,  u64,  u64,  u64)’ {aka ‘long long unsigned int (*)(long long unsigned int,  long long unsigned int,  long long unsigned int,  long long unsigned int,  long long unsigned int)’} [-Wcast-function-type]
./include/linux/filter.h:352:14: note: in definition of macro ‘BPF_EMIT_CALL’
kernel/bpf/hashtab.c:551:26: note: in expansion of macro ‘BPF_CAST_CALL’
./include/linux/filter.h:344:4: warning: cast between incompatible function types from ‘void * (*)(struct bpf_map *, void *)’ to ‘u64 (*)(u64,  u64,  u64,  u64,  u64)’ {aka ‘long long unsigned int (*)(long long unsigned int,  long long unsigned int,  long long unsigned int,  long long unsigned int,  long long unsigned int)’} [-Wcast-function-type]
./include/linux/filter.h:352:14: note: in definition of macro ‘BPF_EMIT_CALL’
kernel/bpf/hashtab.c:1488:26: note: in expansion of macro ‘BPF_CAST_CALL’
drivers/firewire/core-cdev.c:985:8: warning: cast between incompatible function types from ‘void (*)(struct fw_iso_context *, dma_addr_t,  void *)’ {aka ‘void (*)(struct fw_iso_context *, long long unsigned int,  void *)’} to ‘void (*)(struct fw_iso_context *, u32,  size_t,  void *, void *)’ {aka ‘void (*)(struct fw_iso_context *, unsigned int,  long unsigned int,  void *, void *)’} [-Wcast-function-type]
kernel/trace/fgraph.c:337:4: warning: cast between incompatible function types from ‘void (*)(long unsigned int,  long unsigned int,  struct ftrace_ops *, struct pt_regs *)’ to ‘void (*)(struct ftrace_graph_ret *)’ [-Wcast-function-type]
kernel/trace/fgraph.c:617:24: warning: cast between incompatible function types from ‘void (*)(long unsigned int,  long unsigned int,  struct ftrace_ops *, struct pt_regs *)’ to ‘void (*)(struct ftrace_graph_ret *)’ [-Wcast-function-type]
drivers/net/usb/hso.c:1268:9: warning: cast between incompatible function types from ‘void (*)(struct hso_serial *)’ to ‘void (*)(long unsigned int)’ [-Wcast-function-type]
drivers/net/wireless/broadcom/b43legacy/main.c:3744:8: warning: cast between incompatible function types from ‘void (*)(struct b43legacy_wldev *)’ to ‘void (*)(long unsigned int)’ [-Wcast-function-type]
drivers/net/wireless/intel/ipw2x00/ipw2100.c:6140:35: warning: cast between incompatible function types from ‘void (*)(struct ipw2100_priv *)’ to ‘void (*)(long unsigned int)’ [-Wcast-function-type]
drivers/net/wireless/intel/ipw2x00/ipw2200.c:10683:35: warning: cast between incompatible function types from ‘void (*)(struct ipw_priv *)’ to ‘void (*)(long unsigned int)’ [-Wcast-function-type]
drivers/net/wireless/intel/iwlegacy/4965-mac.c:6240:8: warning: cast between incompatible function types from ‘void (*)(struct il_priv *)’ to ‘void (*)(long unsigned int)’ [-Wcast-function-type]
drivers/net/usb/usbnet.c:1703:17: warning: cast between incompatible function types from ‘void (*)(struct timer_list *)’ to ‘void (*)(long unsigned int)’ [-Wcast-function-type]
drivers/net/wireless/intel/iwlegacy/3945-mac.c:3404:8: warning: cast between incompatible function types from ‘void (*)(struct il_priv *)’ to ‘void (*)(long unsigned int)’ [-Wcast-function-type]
drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c:293:6: note: while referencing ‘eth_addr’
drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c:288:6: note: while referencing ‘eth_addr_mask’
drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c:288:6: note: while referencing ‘eth_addr_mask’
drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c:288:6: note: while referencing ‘eth_addr_mask’
drivers/net/wireless/realtek/rtlwifi/pci.c:1196:8: warning: cast between incompatible function types from ‘void (*)(struct ieee80211_hw *)’ to ‘void (*)(long unsigned int)’ [-Wcast-function-type]
drivers/net/wireless/realtek/rtlwifi/pci.c:1199:8: warning: cast between incompatible function types from ‘void (*)(struct ieee80211_hw *)’ to ‘void (*)(long unsigned int)’ [-Wcast-function-type]
drivers/scsi/aacraid/aachba.c:813:23: warning: cast between incompatible function types from ‘int (*)(struct scsi_cmnd *)’ to ‘void (*)(struct scsi_cmnd *)’ [-Wcast-function-type]

fengguang pushed a commit to 0day-ci/linux that referenced this issue Nov 24, 2019
@phongt @intel-lab-lkp
drivers: net: hso: Fix -Wcast-function-type
c824906 
correct usage prototype of callback in tasklet_init().
Report by KSPP#20

Signed-off-by: Phong Tran <tranmanphong@gmail.com>
fengguang pushed a commit to 0day-ci/linux that referenced this issue Nov 24, 2019
@phongt @intel-lab-lkp
drivers: net: usbnet: Fix -Wcast-function-type
4888adb 
correct usage prototype of callback in tasklet_init().
Report by KSPP#20

Signed-off-by: Phong Tran <tranmanphong@gmail.com>
fengguang pushed a commit to 0day-ci/linux that referenced this issue Nov 24, 2019
@phongt @intel-lab-lkp
drivers: net: b43legacy: Fix -Wcast-function-type
061007e 
correct usage prototype of callback in tasklet_init().
Report by KSPP#20

Signed-off-by: Phong Tran <tranmanphong@gmail.com>
fengguang pushed a commit to 0day-ci/linux that referenced this issue Nov 24, 2019
@phongt @intel-lab-lkp
drivers: net: intel: Fix -Wcast-function-type
fead0df 
correct usage prototype of callback in tasklet_init().
Report by KSPP#20

Signed-off-by: Phong Tran <tranmanphong@gmail.com>
fengguang pushed a commit to 0day-ci/linux that referenced this issue Nov 24, 2019
@phongt @intel-lab-lkp
drivers: net: realtek: Fix -Wcast-function-type
fa37c7f 
correct usage prototype of callback in tasklet_init().
Report by KSPP#20

Signed-off-by: Phong Tran <tranmanphong@gmail.com>
fengguang pushed a commit to 0day-ci/linux that referenced this issue Nov 25, 2019
@phongt @intel-lab-lkp
drivers: net: hso: Fix -Wcast-function-type
3c4b0f7 
correct usage prototype of callback in tasklet_init().
Report by KSPP#20

Signed-off-by: Phong Tran <tranmanphong@gmail.com>
fengguang pushed a commit to 0day-ci/linux that referenced this issue Nov 25, 2019
@phongt @intel-lab-lkp
drivers: net: usbnet: Fix -Wcast-function-type
b8d4e1c 
correct usage prototype of callback in tasklet_init().
Report by KSPP#20

Signed-off-by: Phong Tran <tranmanphong@gmail.com>
fengguang pushed a commit to 0day-ci/linux that referenced this issue Nov 25, 2019
@phongt @intel-lab-lkp
drivers: net: b43legacy: Fix -Wcast-function-type
29325b0 
correct usage prototype of callback in tasklet_init().
Report by KSPP#20

Signed-off-by: Phong Tran <tranmanphong@gmail.com>
fengguang pushed a commit to 0day-ci/linux that referenced this issue Nov 25, 2019
@phongt @intel-lab-lkp
drivers: net: intel: Fix -Wcast-function-type
3497781 
correct usage prototype of callback in tasklet_init().
Report by KSPP#20

Signed-off-by: Phong Tran <tranmanphong@gmail.com>
fengguang pushed a commit to 0day-ci/linux that referenced this issue Nov 25, 2019
@phongt @intel-lab-lkp
drivers: net: realtek: Fix -Wcast-function-type
257feba 
correct usage prototype of callback in tasklet_init().
Report by KSPP#20

Signed-off-by: Phong Tran <tranmanphong@gmail.com>
fengguang pushed a commit to 0day-ci/linux that referenced this issue Nov 26, 2019
@phongt @davem330
net: hso: Fix -Wcast-function-type
1d4a09d 
correct usage prototype of callback in tasklet_init().
Report by KSPP#20

Signed-off-by: Phong Tran <tranmanphong@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
fengguang pushed a commit to 0day-ci/linux that referenced this issue Nov 26, 2019
@phongt @davem330
net: usbnet: Fix -Wcast-function-type
2eb1d3f 
correct usage prototype of callback in tasklet_init().
Report by KSPP#20

Signed-off-by: Phong Tran <tranmanphong@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
ruscur pushed a commit to ruscur/linux that referenced this issue Dec 19, 2019
@phongt
b43legacy: Fix -Wcast-function-type
475eec1 
correct usage prototype of callback in tasklet_init().
Report by KSPP#20

Tested-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Phong Tran <tranmanphong@gmail.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
ruscur pushed a commit to ruscur/linux that referenced this issue Dec 19, 2019
@phongt
ipw2x00: Fix -Wcast-function-type
ebd77fe 
correct usage prototype of callback in tasklet_init().
Report by KSPP#20

Signed-off-by: Phong Tran <tranmanphong@gmail.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
ruscur pushed a commit to ruscur/linux that referenced this issue Dec 19, 2019
@phongt
iwlegacy: Fix -Wcast-function-type
da5e57e 
correct usage prototype of callback in tasklet_init().
Report by KSPP#20

Signed-off-by: Phong Tran <tranmanphong@gmail.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
ruscur pushed a commit to ruscur/linux that referenced this issue Dec 19, 2019
@phongt
rtlwifi: rtl_pci: Fix -Wcast-function-type
cb775c8 
correct usage prototype of callback in tasklet_init().
Report by KSPP#20

Signed-off-by: Phong Tran <tranmanphong@gmail.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
rokibhasansagar pushed a commit to rokibhasansagar/aosp_common_kernels that referenced this issue Jan 11, 2020
@phongt @adelva1984
UPSTREAM: net: usbnet: Fix -Wcast-function-type
b68f613 
correct usage prototype of callback in tasklet_init().
Report by KSPP/linux#20

Signed-off-by: Phong Tran <tranmanphong@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
(cherry picked from commit 2eb1d3f4bcae6c83943214ccb26968a48360db06)
Bug: 147506196
Change-Id: Ia9d7fe3e8118c2570ae037645e259082bd813222
Signed-off-by: Alistair Delva <adelva@google.com>
Jackeagle pushed a commit to Jackeagle/kernel_msm that referenced this issue Jan 11, 2020
@phongt @adelva1984
UPSTREAM: net: usbnet: Fix -Wcast-function-type
30382b0 
correct usage prototype of callback in tasklet_init().
Report by KSPP/linux#20

Signed-off-by: Phong Tran <tranmanphong@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
(cherry picked from commit 2eb1d3f)
Bug: 147506196
Change-Id: Ia9d7fe3e8118c2570ae037645e259082bd813222
Signed-off-by: Alistair Delva <adelva@google.com>
vineethrp pushed a commit to vineethrp/pinephone-linux that referenced this issue Feb 12, 2020
@phongt @vineethrp
UPSTREAM: net: usbnet: Fix -Wcast-function-type
86647c4 
correct usage prototype of callback in tasklet_init().
Report by KSPP/linux#20

Signed-off-by: Phong Tran <tranmanphong@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
(cherry picked from commit 2eb1d3f)
Bug: 147506196
Change-Id: Ia9d7fe3e8118c2570ae037645e259082bd813222
Signed-off-by: Alistair Delva <adelva@google.com>
Boos4721 pushed a commit to Boos4721/op6_kernel that referenced this issue Feb 23, 2020
@phongt @gregkh
b43legacy: Fix -Wcast-function-type
ec7d2b7 
[ Upstream commit 475eec112e4267232d10f4afe2f939a241692b6c ]

correct usage prototype of callback in tasklet_init().
Report by KSPP/linux#20

Tested-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Phong Tran <tranmanphong@gmail.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Boos4721 pushed a commit to Boos4721/op6_kernel that referenced this issue Feb 23, 2020
@phongt @gregkh
ipw2x00: Fix -Wcast-function-type
23b06a7 
[ Upstream commit ebd77feb27e91bb5fe35a7818b7c13ea7435fb98 ]

correct usage prototype of callback in tasklet_init().
Report by KSPP/linux#20

Signed-off-by: Phong Tran <tranmanphong@gmail.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Boos4721 pushed a commit to Boos4721/op6_kernel that referenced this issue Feb 23, 2020
@phongt @gregkh
iwlegacy: Fix -Wcast-function-type
ed94a08 
[ Upstream commit da5e57e8a6a3e69dac2937ba63fa86355628fbb2 ]

correct usage prototype of callback in tasklet_init().
Report by KSPP/linux#20

Signed-off-by: Phong Tran <tranmanphong@gmail.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Boos4721 pushed a commit to Boos4721/op6_kernel that referenced this issue Feb 23, 2020
@phongt @gregkh
rtlwifi: rtl_pci: Fix -Wcast-function-type
e4c044f 
[ Upstream commit cb775c88da5d48a85d99d95219f637b6fad2e0e9 ]

correct usage prototype of callback in tasklet_init().
Report by KSPP/linux#20

Signed-off-by: Phong Tran <tranmanphong@gmail.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Whissi pushed a commit to Whissi/linux-stable that referenced this issue Feb 24, 2020
@phongt @gregkh
b43legacy: Fix -Wcast-function-type
b213d74 
[ Upstream commit 475eec1 ]

correct usage prototype of callback in tasklet_init().
Report by KSPP/linux#20

Tested-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Phong Tran <tranmanphong@gmail.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Whissi pushed a commit to Whissi/linux-stable that referenced this issue Feb 24, 2020
@phongt @gregkh
ipw2x00: Fix -Wcast-function-type
0bfca57 
[ Upstream commit ebd77fe ]

correct usage prototype of callback in tasklet_init().
Report by KSPP/linux#20

Signed-off-by: Phong Tran <tranmanphong@gmail.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Whissi pushed a commit to Whissi/linux-stable that referenced this issue Feb 24, 2020
@phongt @gregkh
iwlegacy: Fix -Wcast-function-type
b33327e 
[ Upstream commit da5e57e ]

correct usage prototype of callback in tasklet_init().
Report by KSPP/linux#20

Signed-off-by: Phong Tran <tranmanphong@gmail.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Whissi pushed a commit to Whissi/linux-stable that referenced this issue Feb 24, 2020
@phongt @gregkh
rtlwifi: rtl_pci: Fix -Wcast-function-type
6d91568 
[ Upstream commit cb775c8 ]

correct usage prototype of callback in tasklet_init().
Report by KSPP/linux#20

Signed-off-by: Phong Tran <tranmanphong@gmail.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Whissi pushed a commit to Whissi/linux-stable that referenced this issue Feb 24, 2020
@phongt @gregkh
b43legacy: Fix -Wcast-function-type
bc87467 
[ Upstream commit 475eec1 ]

correct usage prototype of callback in tasklet_init().
Report by KSPP/linux#20

Tested-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Phong Tran <tranmanphong@gmail.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Unnho pushed a commit to Unnho/android_kernel_samsung_sdm439 that referenced this issue Dec 20, 2023
@phongt @Unnho
iwlegacy: Fix -Wcast-function-type
aa19916 
[ Upstream commit da5e57e8a6a3e69dac2937ba63fa86355628fbb2 ]

correct usage prototype of callback in tasklet_init().
Report by KSPP/linux#20

Signed-off-by: Phong Tran <tranmanphong@gmail.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Unnho pushed a commit to Unnho/android_kernel_samsung_sdm439 that referenced this issue Dec 20, 2023
@phongt @Unnho
rtlwifi: rtl_pci: Fix -Wcast-function-type
386ae93 
[ Upstream commit cb775c88da5d48a85d99d95219f637b6fad2e0e9 ]

correct usage prototype of callback in tasklet_init().
Report by KSPP/linux#20

Signed-off-by: Phong Tran <tranmanphong@gmail.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
kevios12 pushed a commit to kevios12/android_kernel_samsung_universal7885 that referenced this issue Feb 16, 2024
@phongt @kevios12
b43legacy: Fix -Wcast-function-type
6b6427b 
[ Upstream commit 475eec112e4267232d10f4afe2f939a241692b6c ]

correct usage prototype of callback in tasklet_init().
Report by KSPP/linux#20

Tested-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Phong Tran <tranmanphong@gmail.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
kevios12 pushed a commit to kevios12/android_kernel_samsung_universal7885 that referenced this issue Feb 16, 2024
@phongt @kevios12
ipw2x00: Fix -Wcast-function-type
88127eb 
[ Upstream commit ebd77feb27e91bb5fe35a7818b7c13ea7435fb98 ]

correct usage prototype of callback in tasklet_init().
Report by KSPP/linux#20

Signed-off-by: Phong Tran <tranmanphong@gmail.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
kevios12 pushed a commit to kevios12/android_kernel_samsung_universal7885 that referenced this issue Feb 16, 2024
@phongt @kevios12
iwlegacy: Fix -Wcast-function-type
95ac7d0 
[ Upstream commit da5e57e8a6a3e69dac2937ba63fa86355628fbb2 ]

correct usage prototype of callback in tasklet_init().
Report by KSPP/linux#20

Signed-off-by: Phong Tran <tranmanphong@gmail.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
kevios12 pushed a commit to kevios12/android_kernel_samsung_universal7885 that referenced this issue Feb 16, 2024
@phongt @kevios12
rtlwifi: rtl_pci: Fix -Wcast-function-type
8904997 
[ Upstream commit cb775c88da5d48a85d99d95219f637b6fad2e0e9 ]

correct usage prototype of callback in tasklet_init().
Report by KSPP/linux#20

Signed-off-by: Phong Tran <tranmanphong@gmail.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
FlorinelulX pushed a commit to FlorinelulX/android_kernel_huawei_hi6250-8 that referenced this issue Feb 20, 2024
@phongt
b43legacy: Fix -Wcast-function-type
b824b88 
[ Upstream commit 475eec112e4267232d10f4afe2f939a241692b6c ]

correct usage prototype of callback in tasklet_init().
Report by KSPP/linux#20

Tested-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Phong Tran <tranmanphong@gmail.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
FlorinelulX pushed a commit to FlorinelulX/android_kernel_huawei_hi6250-8 that referenced this issue Feb 20, 2024
@phongt
ipw2x00: Fix -Wcast-function-type
7325ce9 
[ Upstream commit ebd77feb27e91bb5fe35a7818b7c13ea7435fb98 ]

correct usage prototype of callback in tasklet_init().
Report by KSPP/linux#20

Signed-off-by: Phong Tran <tranmanphong@gmail.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
FlorinelulX pushed a commit to FlorinelulX/android_kernel_huawei_hi6250-8 that referenced this issue Feb 20, 2024
@phongt
iwlegacy: Fix -Wcast-function-type
97c29d8 
[ Upstream commit da5e57e8a6a3e69dac2937ba63fa86355628fbb2 ]

correct usage prototype of callback in tasklet_init().
Report by KSPP/linux#20

Signed-off-by: Phong Tran <tranmanphong@gmail.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
FlorinelulX pushed a commit to FlorinelulX/android_kernel_huawei_hi6250-8 that referenced this issue Feb 20, 2024
@phongt
rtlwifi: rtl_pci: Fix -Wcast-function-type
14f4f08 
[ Upstream commit cb775c88da5d48a85d99d95219f637b6fad2e0e9 ]

correct usage prototype of callback in tasklet_init().
Report by KSPP/linux#20

Signed-off-by: Phong Tran <tranmanphong@gmail.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
hsyncvlk23 pushed a commit to hsyncvlk23/android_kernel-4.9 that referenced this issue Mar 21, 2024
@phongt @hsyncvlk23
b43legacy: Fix -Wcast-function-type
d00d184 
[ Upstream commit 475eec112e4267232d10f4afe2f939a241692b6c ]

correct usage prototype of callback in tasklet_init().
Report by KSPP/linux#20

Tested-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Phong Tran <tranmanphong@gmail.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
hsyncvlk23 pushed a commit to hsyncvlk23/android_kernel-4.9 that referenced this issue Mar 21, 2024
@phongt @hsyncvlk23
ipw2x00: Fix -Wcast-function-type
38b686a 
[ Upstream commit ebd77feb27e91bb5fe35a7818b7c13ea7435fb98 ]

correct usage prototype of callback in tasklet_init().
Report by KSPP/linux#20

Signed-off-by: Phong Tran <tranmanphong@gmail.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
hsyncvlk23 pushed a commit to hsyncvlk23/android_kernel-4.9 that referenced this issue Mar 21, 2024
@phongt @hsyncvlk23
iwlegacy: Fix -Wcast-function-type
8169c4c 
[ Upstream commit da5e57e8a6a3e69dac2937ba63fa86355628fbb2 ]

correct usage prototype of callback in tasklet_init().
Report by KSPP/linux#20

Signed-off-by: Phong Tran <tranmanphong@gmail.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
hsyncvlk23 pushed a commit to hsyncvlk23/android_kernel-4.9 that referenced this issue Mar 21, 2024
@phongt @hsyncvlk23
rtlwifi: rtl_pci: Fix -Wcast-function-type
35167e2 
[ Upstream commit cb775c88da5d48a85d99d95219f637b6fad2e0e9 ]

correct usage prototype of callback in tasklet_init().
Report by KSPP/linux#20

Signed-off-by: Phong Tran <tranmanphong@gmail.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
LinuxGuy312 pushed a commit to LinuxGuy312/android_kernel_realme_RMX1805 that referenced this issue Mar 23, 2024
@phongt @LinuxGuy312
b43legacy: Fix -Wcast-function-type
e7a6fbf 
[ Upstream commit 475eec112e4267232d10f4afe2f939a241692b6c ]

correct usage prototype of callback in tasklet_init().
Report by KSPP/linux#20

Tested-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Phong Tran <tranmanphong@gmail.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
LinuxGuy312 pushed a commit to LinuxGuy312/android_kernel_realme_RMX1805 that referenced this issue Mar 23, 2024
@phongt @LinuxGuy312
ipw2x00: Fix -Wcast-function-type
a239b2b 
[ Upstream commit ebd77feb27e91bb5fe35a7818b7c13ea7435fb98 ]

correct usage prototype of callback in tasklet_init().
Report by KSPP/linux#20

Signed-off-by: Phong Tran <tranmanphong@gmail.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
LinuxGuy312 pushed a commit to LinuxGuy312/android_kernel_realme_RMX1805 that referenced this issue Mar 23, 2024
@phongt @LinuxGuy312
iwlegacy: Fix -Wcast-function-type
cbc2ee1 
[ Upstream commit da5e57e8a6a3e69dac2937ba63fa86355628fbb2 ]

correct usage prototype of callback in tasklet_init().
Report by KSPP/linux#20

Signed-off-by: Phong Tran <tranmanphong@gmail.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
LinuxGuy312 pushed a commit to LinuxGuy312/android_kernel_realme_RMX1805 that referenced this issue Mar 23, 2024
@phongt @LinuxGuy312
rtlwifi: rtl_pci: Fix -Wcast-function-type
23d1f0d 
[ Upstream commit cb775c88da5d48a85d99d95219f637b6fad2e0e9 ]

correct usage prototype of callback in tasklet_init().
Report by KSPP/linux#20

Signed-off-by: Phong Tran <tranmanphong@gmail.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
svoboda18 pushed a commit to svoboda18/android_blackghost_kernel that referenced this issue Apr 9, 2024
@phongt @svoboda18
b43legacy: Fix -Wcast-function-type
3ac3d1e 
[ Upstream commit 475eec112e4267232d10f4afe2f939a241692b6c ]

correct usage prototype of callback in tasklet_init().
Report by KSPP/linux#20

Tested-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Phong Tran <tranmanphong@gmail.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
svoboda18 pushed a commit to svoboda18/android_blackghost_kernel that referenced this issue Apr 9, 2024
@phongt @svoboda18
ipw2x00: Fix -Wcast-function-type
d689436 
[ Upstream commit ebd77feb27e91bb5fe35a7818b7c13ea7435fb98 ]

correct usage prototype of callback in tasklet_init().
Report by KSPP/linux#20

Signed-off-by: Phong Tran <tranmanphong@gmail.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
svoboda18 pushed a commit to svoboda18/android_blackghost_kernel that referenced this issue Apr 9, 2024
@phongt @svoboda18
iwlegacy: Fix -Wcast-function-type
6c886e0 
[ Upstream commit da5e57e8a6a3e69dac2937ba63fa86355628fbb2 ]

correct usage prototype of callback in tasklet_init().
Report by KSPP/linux#20

Signed-off-by: Phong Tran <tranmanphong@gmail.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
svoboda18 pushed a commit to svoboda18/android_blackghost_kernel that referenced this issue Apr 9, 2024
@phongt @svoboda18
rtlwifi: rtl_pci: Fix -Wcast-function-type
3df727a 
[ Upstream commit cb775c88da5d48a85d99d95219f637b6fad2e0e9 ]

correct usage prototype of callback in tasklet_init().
Report by KSPP/linux#20

Signed-off-by: Phong Tran <tranmanphong@gmail.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Huawei-Dev pushed a commit to Huawei-Dev/android_kernel_huawei_hi3660 that referenced this issue Apr 11, 2024
@phongt @Huawei-Dev
b43legacy: Fix -Wcast-function-type
571d2d7 
[ Upstream commit 475eec112e4267232d10f4afe2f939a241692b6c ]

correct usage prototype of callback in tasklet_init().
Report by KSPP/linux#20

Tested-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Phong Tran <tranmanphong@gmail.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Huawei-Dev pushed a commit to Huawei-Dev/android_kernel_huawei_hi3660 that referenced this issue Apr 11, 2024
@phongt @Huawei-Dev
ipw2x00: Fix -Wcast-function-type
549e199 
[ Upstream commit ebd77feb27e91bb5fe35a7818b7c13ea7435fb98 ]

correct usage prototype of callback in tasklet_init().
Report by KSPP/linux#20

Signed-off-by: Phong Tran <tranmanphong@gmail.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Huawei-Dev pushed a commit to Huawei-Dev/android_kernel_huawei_hi3660 that referenced this issue Apr 11, 2024
@phongt @Huawei-Dev
iwlegacy: Fix -Wcast-function-type
b96a743 
[ Upstream commit da5e57e8a6a3e69dac2937ba63fa86355628fbb2 ]

correct usage prototype of callback in tasklet_init().
Report by KSPP/linux#20

Signed-off-by: Phong Tran <tranmanphong@gmail.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Huawei-Dev pushed a commit to Huawei-Dev/android_kernel_huawei_hi3660 that referenced this issue Apr 11, 2024
@phongt @Huawei-Dev
rtlwifi: rtl_pci: Fix -Wcast-function-type
e2a642c 
[ Upstream commit cb775c88da5d48a85d99d95219f637b6fad2e0e9 ]

correct usage prototype of callback in tasklet_init().
Report by KSPP/linux#20

Signed-off-by: Phong Tran <tranmanphong@gmail.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Huawei-Dev pushed a commit to Huawei-Dev/android_kernel_huawei_hi3660 that referenced this issue Apr 11, 2024
@phongt @Huawei-Dev
b43legacy: Fix -Wcast-function-type
f82e0bd 
[ Upstream commit 475eec112e4267232d10f4afe2f939a241692b6c ]

correct usage prototype of callback in tasklet_init().
Report by KSPP/linux#20

Tested-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Phong Tran <tranmanphong@gmail.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Huawei-Dev pushed a commit to Huawei-Dev/android_kernel_huawei_hi3660 that referenced this issue Apr 11, 2024
@phongt @Huawei-Dev
ipw2x00: Fix -Wcast-function-type
f8f4d67 
[ Upstream commit ebd77feb27e91bb5fe35a7818b7c13ea7435fb98 ]

correct usage prototype of callback in tasklet_init().
Report by KSPP/linux#20

Signed-off-by: Phong Tran <tranmanphong@gmail.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Huawei-Dev pushed a commit to Huawei-Dev/android_kernel_huawei_hi3660 that referenced this issue Apr 11, 2024
@phongt @Huawei-Dev
iwlegacy: Fix -Wcast-function-type
182cd6d 
[ Upstream commit da5e57e8a6a3e69dac2937ba63fa86355628fbb2 ]

correct usage prototype of callback in tasklet_init().
Report by KSPP/linux#20

Signed-off-by: Phong Tran <tranmanphong@gmail.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Huawei-Dev pushed a commit to Huawei-Dev/android_kernel_huawei_hi3660 that referenced this issue Apr 11, 2024
@phongt @Huawei-Dev
rtlwifi: rtl_pci: Fix -Wcast-function-type
9f0df45 
[ Upstream commit cb775c88da5d48a85d99d95219f637b6fad2e0e9 ]

correct usage prototype of callback in tasklet_init().
Report by KSPP/linux#20

Signed-off-by: Phong Tran <tranmanphong@gmail.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GustavoARSilva GustavoARSilva

Labels
[Build] Global flag [Feature] CFI Involves Control Flow Integrity good first issue Good for newcomers [Linux] v5.17 Released in Linux kernel v5.17
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@GustavoARSilva @kees @Blacksuan19