Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace 1-element array in drivers/acpi/acpica/amlresrc.h #248

Closed
PauloMigAlmeida opened this issue Dec 11, 2022 · 4 comments
Closed

Replace 1-element array in drivers/acpi/acpica/amlresrc.h #248

PauloMigAlmeida opened this issue Dec 11, 2022 · 4 comments
Assignees
Labels
[Idiom] fake flexible array [Linux] v6.4 Released in Linux kernel v6.4 [Refactor] 1-element array Conversion away from one-element array

Comments

@PauloMigAlmeida
Copy link
Collaborator

Replace one-element array with flexible-array member:

259 struct aml_resource_extended_irq {
260         AML_RESOURCE_LARGE_HEADER_COMMON u8 flags;
261         u8 interrupt_count;
262         u32 interrupts[1];
263         /* res_source_index, res_source optional fields follow */
264 };
265
@PauloMigAlmeida PauloMigAlmeida self-assigned this Dec 11, 2022
@PauloMigAlmeida
Copy link
Collaborator Author

This header file seems to be generated by a script that lives outside of the Linux kernel code base so according to this chat on the LKML, if one wants to change anything, it should be done on the ACPICA repository instead

https://lore.kernel.org/lkml/1AE640813FDE7649BE1B193DEA596E8802632E24@SHSMSX101.ccr.corp.intel.com/

@PauloMigAlmeida PauloMigAlmeida removed their assignment Dec 12, 2022
@PauloMigAlmeida
Copy link
Collaborator Author

As @kees has already opened a PR to fix this and other stuff, I will keep this open (in case I can be of any help).

@kees kees self-assigned this Feb 6, 2024
@kees kees added the [Linux] v6.4 Released in Linux kernel v6.4 label Feb 6, 2024
@kees
Copy link

kees commented Feb 6, 2024

Fixed in commit 376b0fb.

@kees kees closed this as completed Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Idiom] fake flexible array [Linux] v6.4 Released in Linux kernel v6.4 [Refactor] 1-element array Conversion away from one-element array
Projects
None yet
Development

No branches or pull requests

2 participants