Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build fails on "master" with "error: flexible array member 'OemData' not allowed in otherwise empty struct" #812

Open
rajasrijan opened this issue Nov 12, 2022 · 4 comments
Open

Build fails on "master" with "error: flexible array member 'OemData' not allowed in otherwise empty struct" #812

rajasrijan opened this issue Nov 12, 2022 · 4 comments

Comments

@rajasrijan
Copy link

How to reproduce:

git clone git@github.com:acpica/acpica.git

Cloning into 'acpica'...
remote: Enumerating objects: 143364, done.
remote: Counting objects: 100% (2188/2188), done.
remote: Compressing objects: 100% (699/699), done.
remote: Total 143364 (delta 1610), reused 1981 (delta 1481), pack-reused 141176
Receiving objects: 100% (143364/143364), 157.86 MiB | 15.30 MiB/s, done.
Resolving deltas: 100% (101620/101620), done.

cd acpica/
make

make[1]: Entering directory '/home/srijan/Documents/acpica/generate/unix/acpibin'
obj/acpibin ../../../source/tools/acpibin/abcompare.c
In file included from ../../../source/include/actbl.h:549,
                 from ../../../source/include/acpi.h:169,
                 from ../../../source/tools/acpibin/acpibin.h:152,
                 from ../../../source/tools/acpibin/abcompare.c:152:
../../../source/include/actbl2.h:1553:29: error: flexible array member in a struct with no named members
 1553 |     UINT8                   OemData[];
      |                             ^~~~~~~
make[1]: *** [../Makefile.rules:20: obj/abcompare.o] Error 1
make[1]: Leaving directory '/home/srijan/Documents/acpica/generate/unix/acpibin'
make: *** [generate/unix/Makefile.common:7: acpibin] Error 2
@kees
Copy link
Contributor

kees commented Nov 18, 2022

This needs to use the ACPI_FLEX_ARRAY() helper I add in PR #813

kees added a commit to kees/acpica that referenced this issue Nov 18, 2022
@kees
ACPI_MADT_OEM_DATA: Fix flexible array member definition
cc3a0ab 
Use ACPI_FLEX_ARRAY() helper to define flexible array member alone in a
struct. Fixes issue acpica#812.
jberaud pushed a commit to jberaud/acpica that referenced this issue Nov 30, 2022
@kees @jberaud
ACPI_MADT_OEM_DATA: Fix flexible array member definition
2bc0d0c 
Use ACPI_FLEX_ARRAY() helper to define flexible array member alone in a
struct. Fixes issue acpica#812.
@chelmuth
Copy link

chelmuth commented Dec 2, 2022

Any progress here or in #813 that's not public? Currently, master compiles only when reverting fd6b8f8.

@kees
Copy link
Contributor

kees commented Dec 2, 2022

I'm still waiting for someone to merge my PR. It fixes the problem (and others).

@acpibob
Copy link
Contributor

acpibob commented Dec 2, 2022 via email

@PauloMigAlmeida PauloMigAlmeida mentioned this issue Dec 12, 2022
Closed
kees added a commit to kees/acpica that referenced this issue Mar 2, 2023
@kees
ACPI_MADT_OEM_DATA: Fix flexible array member definition
e7f6d8c 
Use ACPI_FLEX_ARRAY() helper to define flexible array member alone in a
struct. Fixes issue acpica#812.

No binary changes appear in the .text nor .data sections.
gemarcano pushed a commit to gemarcano/acpica that referenced this issue Sep 27, 2023
@kees @gemarcano
ACPI_MADT_OEM_DATA: Fix flexible array member definition
3422446 
Use ACPI_FLEX_ARRAY() helper to define flexible array member alone in a
struct. Fixes issue acpica#812.

No binary changes appear in the .text nor .data sections.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@acpibob @chelmuth @kees @rajasrijan