Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace one-element array flex-array member in drivers/scsi/lpfc/lpfc_hw.h #295

Closed
GustavoARSilva opened this issue May 17, 2023 · 0 comments
Closed

Replace one-element array flex-array member in drivers/scsi/lpfc/lpfc_hw.h #295

GustavoARSilva opened this issue May 17, 2023 · 0 comments
Assignees
@GustavoARSilva
Labels
[Idiom] fake flexible array [PATCH] Exists A patch exists to address the issue [Refactor] 1-element array Conversion away from one-element array

Comments

@GustavoARSilva
Copy link
Collaborator 

diff --git a/drivers/scsi/lpfc/lpfc_hw.h b/drivers/scsi/lpfc/lpfc_hw.h
index 19b2d2754f32..b2123ec4df88 100644
--- a/drivers/scsi/lpfc/lpfc_hw.h
+++ b/drivers/scsi/lpfc/lpfc_hw.h
@@ -1415,12 +1415,12 @@ struct app_id_object {

 struct lpfc_vmid_rapp_ident_list {
        uint32_t no_of_objects;
-       struct entity_id_object obj[1];
+       struct entity_id_object obj[];
 };

 struct lpfc_vmid_dapp_ident_list {
        uint32_t no_of_objects;
-       struct entity_id_object obj[1];
+       struct entity_id_object obj[];
 };
@GustavoARSilva GustavoARSilva self-assigned this May 17, 2023
@GustavoARSilva GustavoARSilva added the [PATCH] Exists A patch exists to address the issue label May 17, 2023
intel-lab-lkp pushed a commit to intel-lab-lkp/linux that referenced this issue May 17, 2023
@GustavoARSilva @intel-lab-lkp
scsi: lpfc: Replace one-element array with flexible-array member
df61c47 
One-element arrays are deprecated, and we are replacing them with flexible
array members instead. So, replace one-element arrays with flexible-array
members in a couple of structures, and refactor the rest of the code,
accordingly.

This helps with the ongoing efforts to tighten the FORTIFY_SOURCE
routines on memcpy() and help us make progress towards globally
enabling -fstrict-flex-arrays=3 [1].

This results in no differences in binary output.

Link: KSPP#79
Link: KSPP#295
Link: https://gcc.gnu.org/pipermail/gcc-patches/2022-October/602902.html [1]
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
1054009064 pushed a commit to 1054009064/linux that referenced this issue May 23, 2023
@GustavoARSilva @martinkpetersen
scsi: lpfc: Replace one-element array with flexible-array member
e90644b 
One-element arrays are deprecated, and we are replacing them with flexible
array members instead. So, replace one-element arrays with flexible-array
members in a couple of structures, and refactor the rest of the code,
accordingly.

This helps with the ongoing efforts to tighten the FORTIFY_SOURCE routines
on memcpy() and help us make progress towards globally enabling
-fstrict-flex-arrays=3 [1].

This results in no differences in binary output.

Link: KSPP#79
Link: KSPP#295
Link: https://gcc.gnu.org/pipermail/gcc-patches/2022-October/602902.html [1]
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Link: https://lore.kernel.org/r/6c6dcab88524c14c47fd06b9332bd96162656db5.1684358315.git.gustavoars@kernel.org
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GustavoARSilva GustavoARSilva

Labels
[Idiom] fake flexible array [PATCH] Exists A patch exists to address the issue [Refactor] 1-element array Conversion away from one-element array
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@GustavoARSilva