Add support for adding assets to AUR repository #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KSXGitHub
reviewed
Aug 4, 2021
| # shellcheck disable=SC2086 | ||
| # Ignore quote rule because we need to expand glob patterns to copy $assets | ||
| { | ||
| echo "Copying " $assets |
There was a problem hiding this comment.
You can remove trailing whitespace after Copying.
|
I will merge this for now, but without creating a tag. You may try it out in your workflow by replacing |
|
Thanks. I won't test it yet as I still have to do a few things with my project, but it will probably be ready this or next week. |
|
Has this been tested? If so could a new tag/release be made? |
Closed
|
Someone is attempting to use this feature: #28 |
|
v2.3.0 has been released. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements support for adding assets to AUR repository and closes #20.
I added
assetskey which can contain glob patterns of additional files that are copied to repo. Globs are expanded by bash and I also addedGLOBIGNORE=".:.."to prevent copying parent directory (..) when trying to match hidden files.I created a test repo that uses this, but with all actual publishing disabled, and it seems to work.