Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add makepkg option - optional basic check that PKGBUILD could be built #31

Merged
merged 2 commits into from
Aug 10, 2022

Conversation

rgeraskin
Copy link
Contributor

It'll be handy to be able to check that makepkg passed without errors before packaging and deploying new release. E.g., file names or paths in the source archive could be changed. And with such "test build" we could catch failed pkg before releasing.

This check is optional. Also, makepkg is launched with --nodeps option for simplicity.

Optional basic check that PKGBUILD could be built
Copy link
Owner

@KSXGitHub KSXGitHub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, please update README.md

action.yml Outdated Show resolved Hide resolved
build.sh Outdated Show resolved Hide resolved
build.sh Outdated Show resolved Hide resolved
@rgeraskin
Copy link
Contributor Author

@KSXGitHub I've renamed makepkg to 'test' and updated readme also

Copy link
Owner

@KSXGitHub KSXGitHub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before merging this, I want to make sure the scripts run without problems. Can you use github-actions-deploy-aur@89cbe4c6760a199744d0e3a15b296f8f53d5d278 in your CI and then let me see the result?

@rgeraskin
Copy link
Contributor Author

@KSXGitHub I use it in my workflows, here you can see yesterday workflow run. Look at Publish AUR package step.

Copy link
Owner

@KSXGitHub KSXGitHub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! Thank you.

@KSXGitHub KSXGitHub merged commit 325b53d into KSXGitHub:master Aug 10, 2022
@KSXGitHub
Copy link
Owner

v2.5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants