Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Contribution to open-source #1749

Merged
merged 9 commits into from
Apr 12, 2022
Merged

Proposal: Contribution to open-source #1749

merged 9 commits into from
Apr 12, 2022

Conversation

lnsandnkth
Copy link

Assignment Proposal

Title

Contributing to Imgbot, friendly robot that optimizes images of your repository

Names and KTH ID

Deadline

Deadline for task 3

Category

Contribution to open-source

Description

Imgbot crawls all your image files in GitHub and submits pull requests after applying a loss less compression.
This will make the file size go down, but leave the dimensions and quality just as good.

I want to dive into the topic of software bots, I never used this project but think it is very useful and I want to contribute to it.

The repo has an active community and is big enough (883 stars)

The issue is relevant and current, issue #1068 is also pinned by a community member.

To resolve this issue, I will add a new feature that will convert the size of the images to the correct respective multi-byte notation.

As I have not yet used this project before, the effort for me should be enough for me to pass this assignment.

repo-link: https://github.com/imgbot/Imgbot

forked repo-link: https://github.com/lnsandn01/Imgbot

Issue to work on:

imgbot/Imgbot#1068

@cesarsotovalero cesarsotovalero self-assigned this Apr 12, 2022
@cesarsotovalero cesarsotovalero added contribution_to_opensource One of the task categories listed in README.md proposal A task proposal labels Apr 12, 2022
@cesarsotovalero
Copy link
Collaborator

Hi @lnsandnkth,
Thanks for the clear and sincere explanation of the task at hand.
This repo is much in the scope of DevOps (I've used it on my own web projects 😄)
Your contribution is small but still significant: it will impact many users.
LGTM!
Good luck.

@cesarsotovalero cesarsotovalero merged commit d5bcb99 into KTH:2022 Apr 12, 2022
@lnsandnkth
Copy link
Author

@cesarsotovalero i just created the pull request at their repo: imgbot/Imgbot#1143
I hope they will merge it
(PS: I used my private github account for this, and not the kth one)

@lnsandnkth
Copy link
Author

@cesarsotovalero, what I did was basically fixing the wrong use of the kb unit in the whole project and then i changed the tostring function of the compression results and adapted/added a corresponding test case. All tests are passing so i think it should be fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution_to_opensource One of the task categories listed in README.md proposal A task proposal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants