Merge pull request #58 from KazariEX/master

fix: duplicate new windows when clicking topic links

components/kun/milkdown/ReadOnly.vue

@@ -7,13 +7,11 @@ import {
   editorViewOptionsCtx
 } from '@milkdown/core'
 import { Milkdown, useEditor } from '@milkdown/vue'
-import { commonmark } from '@milkdown/preset-commonmark'
+import { commonmark, linkAttr } from '@milkdown/preset-commonmark'
 import { gfm } from '@milkdown/preset-gfm'
 
 import { prism, prismConfig } from '@milkdown/plugin-prism'
 import { replaceAll } from '@milkdown/utils'
-import type { EditorView } from 'prosemirror-view'
-import type { Node } from '@milkdown/prose/model'
 
 import '~/assets/css/editor/index.scss'
 
@@ -38,7 +36,7 @@ import tsx from 'refractor/lang/tsx'
 import markdown from 'refractor/lang/markdown'
 
 // Open link on new tab
-import { handleClick } from './plugins/hyperlinkOpen'
+import { handleExternal } from './plugins/hyperlinkExternal'
 
 const props = defineProps<{
   isReadonly: boolean
@@ -61,21 +59,10 @@ const { get, loading } = useEditor((root) =>
 
       ctx.update(editorViewOptionsCtx, (prev) => ({
         ...prev,
-        editable,
-        handleClickOn: (view: EditorView, pos: number, node: Node) =>
-          handleClick(ctx, view, pos, node)
+        editable
       }))
 
-      // preventDefaultClick
-      const observer = new MutationObserver(() => {
-        const links = Array.from(root.querySelectorAll('a'))
-        links.forEach((link) => {
-          link.onclick = () => false
-        })
-      })
-      observer.observe(root, {
-        childList: true
-      })
+      ctx.set(linkAttr.key, handleExternal)
 
       ctx.set(prismConfig.key, {
         configureRefractor: (refractor) => {

components/kun/milkdown/plugins/hyperlinkExternal.ts

@@ -0,0 +1,23 @@
+import { Mark } from '@milkdown/prose/model'
+
+const hasURLProtocol = (url: string) => {
+  return (
+    url.startsWith('http://') ||
+    url.startsWith('https://') ||
+    url.startsWith('file://') ||
+    url.startsWith('data:') ||
+    url.startsWith('ts://?ts') ||
+    url.startsWith('ts:?ts')
+  )
+}
+
+export const handleExternal = (node: Mark) => {
+  const href = node.attrs.href
+  if (typeof href === 'string' && hasURLProtocol(href)) {
+    return {
+      target: '_blank',
+      rel: 'noopener noreferrer'
+    }
+  }
+  return {}
+}

package.json

@@ -1,6 +1,6 @@
 {
   "name": "kun-galgame-nuxt3",
-  "version": "2.11.28",
+  "version": "2.11.29",
   "private": true,
   "scripts": {
     "build": "nuxt build",