Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue new release of TurtleFSI to generate DOI for Nature Comms Paper #92

Closed
dbruneau-mie opened this issue Oct 12, 2023 · 11 comments
Closed

Comments

@dbruneau-mie
Copy link
Collaborator

Hi @keiyamamo @jorgensd @johannesring @KristianValen-Sendstad, I would like to issue a new release (v2.2.1) of TurtleFSI to generate a DOI in Zenodo, so I can reference it in my Nature Comms paper. Do you have any concerns about doing this?

@keiyamamo
Copy link
Collaborator

keiyamamo commented Oct 12, 2023

There is no concerns from my side.

@jorgensd
Copy link
Collaborator

No objections. Frequent releases are good for users anyhow

@johannesring
Copy link
Collaborator

No problem, but it would be good to bump the version number when making a release. There have been a few releases lately, but setup.py is still at version 1.5.

@KristianValen-Sendstad
Copy link

KristianValen-Sendstad commented Oct 12, 2023 via email

@dbruneau-mie
Copy link
Collaborator Author

dbruneau-mie commented Oct 13, 2023 via email

@johannesring
Copy link
Collaborator

Yes, the tests are passing (see here), but the badge at the top of README.md is pointing to a Travis test that does not seem to be running.

@keiyamamo
Copy link
Collaborator

@dbruneau-mie test is automatically run with github everyday. @johannesring We should probably remove travis from readme as well as .travis.yml

@johannesring
Copy link
Collaborator

@keiyamamo - yes, I will do that.

@keiyamamo
Copy link
Collaborator

@johannesring Thanks! For some reason, documentation badge says “failing” even though the documentation looks fine. It would be nice to fix it but I’m not sure when the documentation is built in the current setting.

@johannesring
Copy link
Collaborator

I guess the documentation on readthedocs is autobuilt on commits. It is probably configured on readthedocs.

@dbruneau-mie
Copy link
Collaborator Author

I created a new release, but could not get zenodo to automatically create a DOI. I ended up archiving an older version of the repo manually at:

https://zenodo.org/doi/10.5281/zenodo.10001935

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants