Oops two lines of unsafe code and I do a double free

KWARC · Mar 26, 2022 · 84e7b08 · 84e7b08
1 parent 6617a19
commit 84e7b08
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/src/xpath.rs b/src/xpath.rs
@@ -257,6 +257,8 @@ pub fn xml_xpath_compiles(xpath: &str) -> bool {
   let c_xpath = CString::new(xpath).unwrap();
     let xml_xpath_comp_expr_ptr = unsafe { xmlXPathCompile(c_xpath.as_bytes().as_ptr()) };
     let result = !xml_xpath_comp_expr_ptr.is_null();
-    unsafe { libc::free(xml_xpath_comp_expr_ptr as *mut c_void); }
+    if result {
+      unsafe { libc::free(xml_xpath_comp_expr_ptr as *mut c_void); }
+    }
     result
 }