RoNode: read-only parallelization with minimal overhead #53
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A simple and pragmatic take on a multi-threaded primitive (see #47 ).
A benchmark on a huge 112 MB XML file with this PR reveals:
Where the single thread uses the Node implementation of master, while the
read-only
and multi thread benchmarks use the newRoNode
construct.The pragmatics of the PR were:
RoNode
primitive and related logic for using it.RoNode
is justNode
with all mutation and bookkeeping removed, including related methods. A bit of boilerplate overload to copy-paste it all, one could imagine it becoming aNodeReader
trait instead.Sync
andSend
are declared safe onRoNode
, while they aren't onNode
, which uses single-threaded abstractions.As you can see from the sample benchmark, on a huge file with a very minimal compute job you get a 10x speedup when running using rayon parallel iterators on my 32 logical thread CPU.