Add warning message when starting a non-global run #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case the map is the wrong version, or the server is not updated the user might not realize that the run will not be saved in the global api. To avoid the confusion, we show them an error message. To prevent spam of the message, we first check if the server is intended to be global, by verifying that the GlobalApi plugin has a key set. Further if the user already has a run going when resetting the timer, they will not get the message again. If they stop the timer and start it again, it will show the message again.
This allows server owners to disable the warnings for non-global maps. This is useful in cases where you host a lot of non-global maps on your server. The default value is to warn users about non-global times, as most servers that have the GlobalAPI Key set mainly host global maps.
walliski
force-pushed
the
warn-non-global
branch
from
eaeeda9
to
0bd0b3c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case the map is the wrong version, or the server is not updated the
user might not realize that the run will not be saved in the global api.
To avoid the confusion, we show them an error message.
To prevent spam of the message, we first check if the server is intended
to be global, by verifying that the GlobalApi plugin has a key set.
Further if the user already has a run going when resetting the timer,
they will not get the message again. If they stop the timer and start it
again, it will show the message again.
Implements: #316