Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HD Wallet - slight differences between ECDSA and Schnorr #27

Closed
briancrypto opened this issue Jul 30, 2020 · 2 comments
Closed

HD Wallet - slight differences between ECDSA and Schnorr #27

briancrypto opened this issue Jul 30, 2020 · 2 comments

Comments

@briancrypto
Copy link

briancrypto commented Jul 30, 2020

Hi,

I noticed the formula used to generate public key in HD Wallet for ECDSA and Schnorr is slightly different.

In ECDSA, it is link to code
let pub_key = pubkey * &f_l_fe;

In Schnorr, it is link to code
let pub_key = pubkey.clone() + &g * &f_l_fe;

Is there some security issue hence the need to multiply the Schnorr public key with generator?

Thanks!

@omershlo
Copy link
Contributor

Hi @briancrypto ,
There is no security issue here, In ECDSA we used multiplicative update because the 2 party protocol in the paper we implemented dictated multiplicative sharing of the private key. In fact, The paper could have been written using additive secret sharing and work fine.

For the same reason - we use additive updates in Schnorr, since the protocol is based on additive secret sharing.

@briancrypto
Copy link
Author

Understood. It is nice to use the same additive/multiplicative across ECDSA or Schnorr, then it will be the same codebase for both.

Thanks for the info!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants