New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sign_stage6 seems not to do what it's meant to #128
Comments
Thanks @DmytroTym !! |
That looks wrong.. and you are right @DmytroTym . I'll try to put up a pr to fix this. |
Great, thanks for the quick response! |
I have another question, but don't want to open a separate issue as I am not sure it deserves it. When we do MtAwc for |
Thanks @DmytroTym your feedback is extremely helpful. We identified this issue as well and it will be resolved in the upcoming PR. please send me an email to omer@zengo.com or ping me in telegram @omershlo - I would like to offer you a reward |
fixed in #130 |
Hello,
I was going through the library and got stuck at
sign_stage6
method oforchestrate.rs
. If I understand correctly, it corresponds to this line at page 15 of GG20 (specifically, the zero-knowledge proof part of it):But from the code it seems that we actually prove the statement
t
times, just with different Fujisaki-Okamoto commitments, and then verify our own proofs instead of broadcasting them. Also, I don't really understand why this stage is called in online stage of signing protocol (paper seems to suggest it can be done offline). Am I missing something?Thanks!
The text was updated successfully, but these errors were encountered: