Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Avoid crash when \ce{} is empty #3627

Merged
merged 3 commits into from
May 20, 2022
Merged

Fix: Avoid crash when \ce{} is empty #3627

merged 3 commits into from
May 20, 2022

Conversation

ronkok
Copy link
Collaborator

@ronkok ronkok commented Apr 26, 2022

Prevent a crash when mhchem \ce{} is empty. Fixes #3626.

@codecov
Copy link

codecov bot commented Apr 26, 2022

Codecov Report

Merging #3627 (2de8d8f) into main (d8fc35e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3627   +/-   ##
=======================================
  Coverage   93.50%   93.50%           
=======================================
  Files          90       90           
  Lines        6636     6636           
  Branches     1543     1543           
=======================================
  Hits         6205     6205           
  Misses        400      400           
  Partials       31       31           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 575dab7...2de8d8f. Read the comment docs.

Copy link
Member

@edemaine edemaine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this. Sorry I've been behind on reviews.

contrib/mhchem/mhchem.js Outdated Show resolved Hide resolved
@edemaine edemaine merged commit 4865e45 into KaTeX:main May 20, 2022
KaTeX-bot added a commit that referenced this pull request May 20, 2022
## [0.15.5](v0.15.4...v0.15.5) (2022-05-20)

### Bug Fixes

* Avoid crash when \ce{} is empty ([#3627](#3627)) ([4865e45](4865e45))
@KaTeX-bot
Copy link
Member

🎉 This PR is included in version 0.15.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ronkok ronkok deleted the emptyCE branch May 20, 2022 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

empty chemical formula crashes (mhchem)
3 participants