Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix undefined devServer.app in screenshotter #1085

Merged
merged 1 commit into from Jan 23, 2018
Merged

Fix undefined devServer.app in screenshotter #1085

merged 1 commit into from Jan 23, 2018

Conversation

ylemkimon
Copy link
Member

@ylemkimon ylemkimon commented Jan 23, 2018 •
edited

Fixes #1082, TypeError: Cannot read property 'get' of undefined on Docker for Mac.

See #1082 (comment).

CC @kevinbarabash

@ylemkimon
Fix undefined devServer.app in screenshotter
99ea90f 
Fixes #1082, `TypeError: Cannot read property 'get' of undefined` on
Docker for Mac.
kevinbarabash
kevinbarabash approved these changes Jan 23, 2018
View reviewed changes
Copy link
Member

@kevinbarabash kevinbarabash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the issue for me on MacOS. Thanks!

@kevinbarabash kevinbarabash merged commit d82424c into KaTeX:master Jan 23, 2018
@ylemkimon ylemkimon deleted the mac-docker-screenshotter branch May 20, 2018 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinbarabash kevinbarabash kevinbarabash approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ylemkimon @kevinbarabash