Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor test helpers #1336

Merged
merged 25 commits into from Jul 22, 2018
Merged

Refactor test helpers #1336

merged 25 commits into from Jul 22, 2018

Commits on May 21, 2018

  1. Refactor test helpers 

    * Combine common codes from `parse` and `build`, and dispatch using
`Mode`
* Remove `toNotBuild` and `toNotParse` and use `expect.not`
* Remove `Warning` and instead mock `console.warn`
* Add `expect.toHavePassed` and check whether parse/build succeeded
lazily
* Improve failed test `message`:
  - Use color
  - Print stack traces(excluding internals)
  - Print diff
  - Follow jest matcher output style
    @ylemkimon
    ylemkimon committed May 21, 2018
    16
    Copy the full SHA
    b3dcf40 View commit details
    Browse the repository at this point in the history

  2. Update helpers.js

    @ylemkimon
    ylemkimon committed May 21, 2018
    Copy the full SHA
    6cdff3c View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into jest-test-helpers

    @ylemkimon
    ylemkimon committed May 21, 2018
    Copy the full SHA
    d751297 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2018

  1. Remove toBeTruthy checks 

    getParsed throws an error if parsing fails.
    @ylemkimon
    ylemkimon committed May 24, 2018
    Copy the full SHA
    4250d06 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2018

  1. Merge branch 'master' into jest-test-helpers

    @ylemkimon
    ylemkimon committed Jun 7, 2018
    Copy the full SHA
    7343e48 View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2018

  1. Merge branch 'master' into jest-test-helpers

    @ylemkimon
    ylemkimon committed Jun 16, 2018
    Copy the full SHA
    0c96b20 View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2018

  1. Merge branch 'jest-test-helpers' of https://github.com/ylemkimon/KaTeX … 

    …into jest-test-helpers
    @ylemkimon
    ylemkimon committed Jun 17, 2018
    Copy the full SHA
    6e1773b View commit details
    Browse the repository at this point in the history

  2. Used tagged literals

    @ylemkimon
    ylemkimon committed Jun 17, 2018
    Copy the full SHA
    17ca384 View commit details
    Browse the repository at this point in the history

  3. Use .toHaveLength

    @ylemkimon
    ylemkimon committed Jun 17, 2018
    Copy the full SHA
    721f62f View commit details
    Browse the repository at this point in the history

  4. Use tagged literals

    @ylemkimon
    ylemkimon committed Jun 17, 2018
    Copy the full SHA
    a8c91eb View commit details
    Browse the repository at this point in the history

  5. Use to{Build,Parse}Like where possible 

    * Remove compareParseTree
    @ylemkimon
    ylemkimon committed Jun 17, 2018
    Copy the full SHA
    96cdfa0 View commit details
    Browse the repository at this point in the history

  6. Use snapshot where possible

    @ylemkimon
    ylemkimon committed Jun 17, 2018
    Copy the full SHA
    4ad8dfd View commit details
    Browse the repository at this point in the history

  7. Join into one line where <88 chars

    @ylemkimon
    ylemkimon committed Jun 17, 2018
    Copy the full SHA
    aeb5350 View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2018

  1. Revert console.warn() to throw an error 

    Merge `expectToWarn` to `expectKaTeX`, like
`expect.toFailWithParseError`
    @ylemkimon
    ylemkimon committed Jun 18, 2018
    Copy the full SHA
    4e84e93 View commit details
    Browse the repository at this point in the history

  2. Remove call to console.warn from stack traces

    @ylemkimon
    ylemkimon committed Jun 18, 2018
    Copy the full SHA
    4e387b8 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into jest-test-helpers

    @ylemkimon
    ylemkimon committed Jun 18, 2018
    Copy the full SHA
    6f6865d View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2018

  1. Merge branch 'master' into jest-test-helpers

    @ylemkimon
    ylemkimon committed Jun 24, 2018
    Copy the full SHA
    d89600c View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2018

  1. Merge branch 'master' into jest-test-helpers

    @ylemkimon
    ylemkimon committed Jun 27, 2018
    Copy the full SHA
    527c5b3 View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2018

  1. Merge branch 'master' into jest-test-helpers

    @ylemkimon
    ylemkimon committed Jul 1, 2018
    Copy the full SHA
    92f13b1 View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2018

  1. Fix merge errors

    @ylemkimon
    ylemkimon committed Jul 8, 2018
    Copy the full SHA
    a49c067 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into jest-test-helpers

    @ylemkimon
    ylemkimon committed Jul 8, 2018
    Copy the full SHA
    6572122 View commit details
    Browse the repository at this point in the history

  3. Remove getTree 

    * Move `_getBuilt` into `getBuilt`
* Move default settings and tagging literal support in to `getParsed` 
and `getBuilt`
* Remove stack traces clean-up
* Remove `toHavePassed` matcher
    @ylemkimon
    ylemkimon committed Jul 8, 2018
    Copy the full SHA
    f783eb8 View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2018

  1. Extract expected string construction into printExpectedResult

    @ylemkimon
    ylemkimon committed Jul 9, 2018
    Copy the full SHA
    fc47230 View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2018

  1. Merge branch 'master' into jest-test-helpers

    @ylemkimon
    ylemkimon committed Jul 16, 2018
    Copy the full SHA
    b557735 View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2018

  1. Merge branch 'master' into jest-test-helpers

    @kevinbarabash
    kevinbarabash committed Jul 22, 2018
    Copy the full SHA
    c64ef13 View commit details
    Browse the repository at this point in the history