fix(array): Keep single empty row in AMS environments #2947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In particular prevents empty equation-numbered environment (e.g. `{align}`)
from crashing.
Fix #2944
Codecov Report
@@ Coverage Diff @@
## master #2947 +/- ##
==========================================
+ Coverage 93.92% 93.94% +0.01%
==========================================
Files 87 87
Lines 6326 6327 +1
Branches 1308 1309 +1
==========================================
+ Hits 5942 5944 +2
+ Misses 354 353 -1
Partials 30 30
Continue to review full report at Codecov.
|
ylemkimon
approved these changes
Apr 24, 2021
KaTeX-bot
added a commit
that referenced
this pull request
Apr 24, 2021
## [0.13.3](v0.13.2...v0.13.3) (2021-04-24) ### Bug Fixes * Respect catcode in macro expansion and set ~'s catcode correctly ([#2949](#2949)) ([01ae7f8](01ae7f8)), closes [#2924](#2924) * **array:** Keep single empty row in AMS environments ([#2947](#2947)) ([24332e0](24332e0)), closes [#2944](#2944)
|
🎉 This PR is included in version 0.13.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
@ylemkimon Thanks for the reviews! How did you do a release with two PR fixes in it? (this one and #2949) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I experimented in LaTeX, and it seems that
{align},{align*}, and even{aligned}environments (basically, all AMS environments) keep a single empty row if there is one, but remove a trailing empty row otherwise. This PR implements this behavior.This in particular prevents empty equation-numbered environment (e.g.
{align}) from crashing (fix #2944).