-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Spelling #3762
chore: Spelling #3762
Conversation
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most corrections automatically suggested by Google Sheets. All fault mine.
- docs: update Gastby logo and link (#2481) | ||
- docs: update Gatsby logo and link (#2481) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a brand.
@@ -1,5 +1,5 @@ | |||
/* eslint-disable */ | |||
/* -*- Mode: Javascript; indent-tabs-mode:nil; js-indent-level: 2 -*- */ | |||
/* -*- Mode: JavaScript; indent-tabs-mode:nil; js-indent-level: 2 -*- */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Brand
// All surds have 0.08em padding above the viniculum inside the SVG. | ||
// All surds have 0.08em padding above the vinculum inside the SVG. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This item is consistently spelled this way, but the world disagrees...
https://www.merriam-webster.com/dictionary/vinculum
this is a TI(re)L - Google Sheets told me.
Good stuff. @edemaine I think you are the right person to decide if the variable name in All the rest looks good to me. |
Thanks @ronkok for reviewing! I agree that |
Codecov Report
@@ Coverage Diff @@
## main #3762 +/- ##
=======================================
Coverage 92.98% 92.98%
=======================================
Files 91 91
Lines 6770 6770
Branches 1574 1574
=======================================
Hits 6295 6295
Misses 437 437
Partials 38 38
Continue to review full report in Codecov by Sentry.
|
P.S. I think adding the "check spelling" action would be cool, as a separate PR, if there aren't any false positives (or there's an easy way to deal with them). |
Oops. Sorry (I failed to properly fill out the description -- fixed...). In regard to adding check-spelling..., you can see the configuration for check-spelling here: jsoref@55adbfb functionally, https://github.com/jsoref/KaTeX/blob/55adbfb034441663fe62209bd9442cd750a7869b/.github/actions/spelling/expect.txt is a list of terms that check-spelling doesn't naturally recognize (with the addition of supplemental dictionaries) and that I didn't recognize as typos of anything else. You could think of them as "false-positives". As for dealing w/ false-positives, I've been working on improving the flow. At this point, the current "easiest" approach can be seen in jsoref@55adbfb#commitcomment-94184527
Basically the command will update the metadata and let you commit them. There's also a provision for updating metadata using a PR comment (which my company uses), but I don't have examples of it being generally deployed in public repositories. I welcome feedback (it does take me some time to digest the feedback and implement a response, and this is a side project, but I try to be fairly responsive). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay on this. Feel free to submit a PR that adds this to the CI workflow; I imagine you'd be the expert on that.
🎉 This PR is included in version 0.16.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This PR corrects misspellings identified by the check-spelling action.
What is the previous behavior before this PR?
The misspellings have been reported at jsoref@55adbfb
What is the new behavior after this PR?
The action reports that the changes in this PR would make it happy: jsoref@dfc30bb
Note: this PR does not include the action. If you're interested in running a spell check on every PR and push, that can be offered separately.